-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2 inventory plugin does not work without region or regions field #1551
Comments
Thanks for taking the time to open this issue. It's actually asking for |
@tremble But this does not invalidate the behaviour change. With 5.1.0 , going without |
Thanks, that confirms the issue is where I thought it was and gives us a work around if necessary. Hopefully, #1552 will properly fix the issue. |
Thanks for the fast turnaround ! |
…ing to pull a list of regions (#1552) inventory plugins - Hard code fall-back region to connect to when trying to pull a list of regions SUMMARY fixes: #1551 If no regions and no region is provided, then botocore will sometimes refuse to connect to the EC2 endpoint for us to then pull a list of regions... ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ec2 inventory plugin ADDITIONAL INFORMATION Nominally botocore should be falling back to a default region, but there are no guarantees Reviewed-by: Alina Buzachis
…ing to pull a list of regions (#1552) inventory plugins - Hard code fall-back region to connect to when trying to pull a list of regions SUMMARY fixes: #1551 If no regions and no region is provided, then botocore will sometimes refuse to connect to the EC2 endpoint for us to then pull a list of regions... ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ec2 inventory plugin ADDITIONAL INFORMATION Nominally botocore should be falling back to a default region, but there are no guarantees Reviewed-by: Alina Buzachis (cherry picked from commit c992070)
…ing to pull a list of regions (#1552) (#1556) [PR #1552/c9920701 backport][stable-6] inventory plugins - Hard code fall-back region to connect to when trying to pull a list of regions This is a backport of PR #1552 as merged into main (c992070). SUMMARY fixes: #1551 If no regions and no region is provided, then botocore will sometimes refuse to connect to the EC2 endpoint for us to then pull a list of regions... ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ec2 inventory plugin ADDITIONAL INFORMATION Nominally botocore should be falling back to a default region, but there are no guarantees Reviewed-by: Mark Chappell
…llections#1551) ecs_ecr - Use compare_policies instead of naive dict sort Depends-On: ansible-collections#1550 SUMMARY When comparing policies on the repos ecs_ecr currently uses a very naive sort function. Since we have something more comprehensive, use it. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ecs_ecr.py ADDITIONAL INFORMATION ecs_ecr is currently the only module using sort_json_policy_dict and it has poor test coverage. Reviewed-by: Markus Bergholz <[email protected]>
…llections#1551) ecs_ecr - Use compare_policies instead of naive dict sort Depends-On: ansible-collections#1550 SUMMARY When comparing policies on the repos ecs_ecr currently uses a very naive sort function. Since we have something more comprehensive, use it. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ecs_ecr.py ADDITIONAL INFORMATION ecs_ecr is currently the only module using sort_json_policy_dict and it has poor test coverage. Reviewed-by: Markus Bergholz <[email protected]>
…llections#1551) ecs_ecr - Use compare_policies instead of naive dict sort Depends-On: ansible-collections#1550 SUMMARY When comparing policies on the repos ecs_ecr currently uses a very naive sort function. Since we have something more comprehensive, use it. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ecs_ecr.py ADDITIONAL INFORMATION ecs_ecr is currently the only module using sort_json_policy_dict and it has poor test coverage. Reviewed-by: Markus Bergholz <[email protected]>
Summary
According to https://docs.ansible.com/ansible/latest/collections/amazon/aws/aws_ec2_inventory.html ec2 inventory plugin should retrieve nodes from all the regions except the restricted ones (eg gov ones) if you don't specify regions.
region
key is not documented there.but starting 6.0 this does not work anymore.
Similar to the old ansible/ansible#45288 a
Issue Type
Bug Report
Component Name
ec2_inventory
Ansible Version
Collection Versions
AWS SDK versions
Configuration
OS / Environment
ubi8 based execution environment
Steps to Reproduce
Expected Results
Inventories plugin works against all unrestricted regions
Actual Results
Inventory plugin fails because of lack of
regions
Code of Conduct
The text was updated successfully, but these errors were encountered: