Refactor inventory plugins #1218
Conversation
ansibullbot
added
bug
abikouo
force-pushed
the
unittest_aws_rds
branch
from
12c06d6 to
7bb6583
Compare
abikouo
removed
bug
|
I was terrified when I first saw the size of the PR, but it looks pretty cool. I'm not a super huge fan of multi-inheritance because it's often annoying to troubleshoot. I would prefer some composition instead. For instance, we can store an instance of |
abikouo
force-pushed
the
unittest_aws_rds
branch
from
1870f86 to
a5309df
Compare
There was a problem hiding this comment.
I'm not a bit fan of how some of this credential/region-discovery logic is being handled, however changing it is probably worth a separate PR.
I'd like @goneri's input on the remaining unit tests, but I think this is otherwise good enough for now.
plugins/plugin_utils/inventory.py
Outdated
| if iam_role_arn is not None: | ||
| try: | ||
| # Describe regions assuming arn role | ||
| assumed_credentials = self._boto3_assume_role(credentials, resource) |
There was a problem hiding this comment.
There's a lot of separate assume calls going on here, we only need to assume the role once, this should be pulled up to line 114.
These excessive assume calls are probably the root cause of #1091
plugins/plugin_utils/inventory.py
Outdated
| if not regions: | ||
| try: |
There was a problem hiding this comment.
If we're explicitly passed iam_assume_role, it kinda feels like we should be trying the assumed role first, and falling back as an act of last resort.
|
recheck |
|
recheck |
|
recheck |
add unit test for aws_rds inventory reduce time and support aws_rds integration tests
abikouo
force-pushed
the
unittest_aws_rds
branch
from
80f56b4 to
c78aa83
Compare
…sible-collections#1218) Tagging - wafv2_web_acl add support for managing and purging tags SUMMARY Add support for returning tags Add support for updating tags Add support for purge_tags ISSUE TYPE Feature Pull Request COMPONENT NAME wafv2_web_acl wafv2_web_acl_info ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>
…sible-collections#1218) Tagging - wafv2_web_acl add support for managing and purging tags SUMMARY Add support for returning tags Add support for updating tags Add support for purge_tags ISSUE TYPE Feature Pull Request COMPONENT NAME wafv2_web_acl wafv2_web_acl_info ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>
…sible-collections#1218) Tagging - wafv2_web_acl add support for managing and purging tags SUMMARY Add support for returning tags Add support for updating tags Add support for purge_tags ISSUE TYPE Feature Pull Request COMPONENT NAME wafv2_web_acl wafv2_web_acl_info ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>
SUMMARY
ISSUE TYPE
COMPONENT NAME
aws_rdsaws_ec2