rds/tests: use aurora2 cluster by default #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
changed the title
goneri
force-pushed
the
rds-aurora-cluster-default-on-provisioned-EngineMode_26094
branch
from
d0b84a1 to
41dc292
Compare
|
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
integration
Aurora with MySQL 5.6 will be soon deprecated by AWS. See: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.MySQL56.EOL.html Closes: ansible-collections#1228
This reverts commit 8e7ac73.
tremble
force-pushed
the
rds-aurora-cluster-default-on-provisioned-EngineMode_26094
branch
from
2f36deb to
91590a1
Compare
alinabuzachis
approved these changes
Nov 2, 2022
tremble
approved these changes
Nov 2, 2022
markuman
pushed a commit
to markuman/amazon.aws
that referenced
this pull request
Nov 14, 2022
cloudwatchlogs_log_group - Tagging support SUMMARY Ensure cloudwatchlogs_log_group returns values defined in RETURN docs Add support for updating tags (including purge_tags) split cloudwatchlogs_log_group tests Add some basic integration tests for cloudwatchlogs_log_group_info ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME cloudwatchlogs_log_group cloudwatchlogs_log_group_info ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3f8d2fc
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
cloudwatchlogs_log_group - Tagging support SUMMARY Ensure cloudwatchlogs_log_group returns values defined in RETURN docs Add support for updating tags (including purge_tags) split cloudwatchlogs_log_group tests Add some basic integration tests for cloudwatchlogs_log_group_info ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME cloudwatchlogs_log_group cloudwatchlogs_log_group_info ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
cloudwatchlogs_log_group - Tagging support SUMMARY Ensure cloudwatchlogs_log_group returns values defined in RETURN docs Add support for updating tags (including purge_tags) split cloudwatchlogs_log_group tests Add some basic integration tests for cloudwatchlogs_log_group_info ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME cloudwatchlogs_log_group cloudwatchlogs_log_group_info ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
cloudwatchlogs_log_group - Tagging support SUMMARY Ensure cloudwatchlogs_log_group returns values defined in RETURN docs Add support for updating tags (including purge_tags) split cloudwatchlogs_log_group tests Add some basic integration tests for cloudwatchlogs_log_group_info ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME cloudwatchlogs_log_group cloudwatchlogs_log_group_info ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aurora1 (provisioned and serverless) which comes with MySQL 5.6 will be soon deprecated by AWS.
See: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.MySQL56.EOL.html
This commit also reverses change 8e7ac73.
Closes: #1228