Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lambda_layer_info - add support for version_number #1293

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
minor_changes:
- lambda_layer_info - add support for parameter version_number to retrieve detailed information for a specific layer version (https://github.com/ansible-collections/amazon.aws/pull/1241).
82 changes: 70 additions & 12 deletions plugins/modules/lambda_layer_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@
type: str
aliases:
- layer_name
version_number:
description:
- The Lambda layer version number to retrieve.
- Requires I(name) to be provided.
type: int
aliases:
- layer_version
abikouo marked this conversation as resolved.
Show resolved Hide resolved
version_added: 5.2.0
compatible_runtime:
description:
- A runtime identifier.
Expand Down Expand Up @@ -62,6 +70,12 @@
- name: list latest versions for all layers
amazon.aws.lambda_layer_info:
compatible_runtime: python3.7

# Retrieve specific lambda layer information
- name: Get lambda layer version information
amazon.aws.lambda_layer_info:
name: my-layer
version_number: 1
'''

RETURN = '''
Expand Down Expand Up @@ -110,6 +124,30 @@
description: A list of compatible instruction set architectures.
returned: if it was defined for the layer version.
type: list
content:
abikouo marked this conversation as resolved.
Show resolved Hide resolved
description: Details about the layer version.
returned: if I(version_number) was provided
type: complex
version_added: 5.2.0
contains:
location:
description: A link to the layer archive in Amazon S3 that is valid for 10 minutes.
type: str
sample: 'https://awslambda-us-east-2-layers.s3.us-east-2.amazonaws.com/snapshots/123456789012/mylayer-4aaa2fbb-96a?versionId=27iWyA73c...'
code_sha256:
description: The SHA-256 hash of the layer archive.
type: str
sample: 'tv9jJO+rPbXUUXuRKi7CwHzKtLDkDRJLB3cC3Z/ouXo='
code_size:
description: The size of the layer archive in bytes.
type: int
sample: 169
signing_profile_version_arn:
description: The Amazon Resource Name (ARN) for a signing profile version.
type: str
signing_job_arn:
description: The Amazon Resource Name (ARN) of a signing job.
type: str
'''

try:
Expand Down Expand Up @@ -175,23 +213,39 @@ def list_layers(lambda_client, compatible_runtime=None, compatible_architecture=
raise LambdaLayerInfoFailure(exc=e, msg="Unable to list layers {0}".format(params))


def get_layer_version(lambda_client, layer_name, version_number):

try:
layer_version = lambda_client.get_layer_version(LayerName=layer_name, VersionNumber=version_number)
if layer_version:
layer_version.pop("ResponseMetadata")
return [camel_dict_to_snake_dict(layer_version)]
except (botocore.exceptions.ClientError, botocore.exceptions.BotoCoreError) as e:
raise LambdaLayerInfoFailure(exc=e, msg="get_layer_version() failed.")


def execute_module(module, lambda_client):

params = {}
f_operation = list_layers
name = module.params.get("name")
if name is not None:
f_operation = list_layer_versions
params["name"] = name
compatible_runtime = module.params.get("compatible_runtime")
if compatible_runtime is not None:
params["compatible_runtime"] = compatible_runtime
compatible_architecture = module.params.get("compatible_architecture")
if compatible_architecture is not None:
params["compatible_architecture"] = compatible_architecture
version_number = module.params.get("version_number")

try:
result = f_operation(lambda_client, **params)
if name is not None and version_number is not None:
result = get_layer_version(lambda_client, name, version_number)
else:
params = {}
f_operation = list_layers
if name is not None:
f_operation = list_layer_versions
params["name"] = name
compatible_runtime = module.params.get("compatible_runtime")
if compatible_runtime is not None:
params["compatible_runtime"] = compatible_runtime
compatible_architecture = module.params.get("compatible_architecture")
if compatible_architecture is not None:
params["compatible_architecture"] = compatible_architecture
result = f_operation(lambda_client, **params)

module.exit_json(changed=False, layers_versions=result)
except LambdaLayerInfoFailure as e:
module.fail_json_aws(exception=e.exc, msg=e.msg)
Expand All @@ -202,11 +256,15 @@ def main():
name=dict(type="str", aliases=["layer_name"]),
compatible_runtime=dict(type="str"),
compatible_architecture=dict(type="str"),
version_number=dict(type="int", aliases=["layer_version"]),
)

module = AnsibleAWSModule(
argument_spec=argument_spec,
supports_check_mode=True,
required_by=dict(
version_number=('name', )
)
)

lambda_client = module.client('lambda')
Expand Down
61 changes: 61 additions & 0 deletions tests/unit/plugins/modules/test_lambda_layer_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,67 @@ def raise_botocore_exception():
return BotoCoreError(error="failed", operation="list_layers")


def test_get_layer_version_success():

aws_layer_version = {
"CompatibleRuntimes": [
"python3.8"
],
"Content": {
"CodeSha256": "vqxKx6nTW31obVcB4MYaTWv5H3fBQTn2PHklL9+mF9E=",
"CodeSize": 9492621,
"Location": "https://test.s3.us-east-1.amazonaws.com/snapshots/123456789012/test-79b29d149e06?versionId=nmEKA3ZgiP7hce3J"
},
"CreatedDate": "2022-12-05T10:47:32.379+0000",
"Description": "Python units test layer",
"LayerArn": "arn:aws:lambda:us-east-1:123456789012:layer:test",
"LayerVersionArn": "arn:aws:lambda:us-east-1:123456789012:layer:test:2",
"LicenseInfo": "GPL-3.0-only",
"Version": 2,
"ResponseMetadata": {
"some-metadata": "some-result"
}
}

ansible_layer_version = {
"compatible_runtimes": [
"python3.8"
],
"content": {
"code_sha256": "vqxKx6nTW31obVcB4MYaTWv5H3fBQTn2PHklL9+mF9E=",
"code_size": 9492621,
"location": "https://test.s3.us-east-1.amazonaws.com/snapshots/123456789012/test-79b29d149e06?versionId=nmEKA3ZgiP7hce3J"
},
"created_date": "2022-12-05T10:47:32.379+0000",
"description": "Python units test layer",
"layer_arn": "arn:aws:lambda:us-east-1:123456789012:layer:test",
"layer_version_arn": "arn:aws:lambda:us-east-1:123456789012:layer:test:2",
"license_info": "GPL-3.0-only",
"version": 2
}

lambda_client = MagicMock()
lambda_client.get_layer_version.return_value = aws_layer_version

layer_name = "test"
layer_version = 2

assert [ansible_layer_version] == lambda_layer_info.get_layer_version(lambda_client, layer_name, layer_version)
lambda_client.get_layer_version.assert_called_once_with(LayerName=layer_name, VersionNumber=layer_version)


def test_get_layer_version_failure():

lambda_client = MagicMock()
lambda_client.get_layer_version.side_effect = raise_botocore_exception()

layer_name = MagicMock()
layer_version = MagicMock()

with pytest.raises(lambda_layer_info.LambdaLayerInfoFailure):
lambda_layer_info.get_layer_version(lambda_client, layer_name, layer_version)


@pytest.mark.parametrize(
"params",
[
Expand Down