Big Black PR #1465
Merged
Big Black PR #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This comment was marked as resolved.
This comment was marked as resolved.
abikouo
approved these changes
Apr 21, 2023
This comment was marked as resolved.
This comment was marked as resolved.
|
@alinabuzachis pylint didn't like where black had moved the linting comments. |
alinabuzachis
approved these changes
Apr 21, 2023
|
recheck |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In preparation for 6.0.0 we agreed to mass apply the black formatter to our code base.
Hopefully we're only a couple of weeks out now, and we're much more on top of our PRs than we used to be. This is the big PR...
ISSUE TYPE
COMPONENT NAME
plugins/
tests/
ADDITIONAL INFORMATION
There are two commits, the first "pre-tunes" a few things so that they're not exploded into lots of extra lines, or squashed into one line. The second is just the result of
black plugins/ testsThe integration tests are highly likely to fail, because this is going to trigger pretty much everything in amazon.aws and community.aws