From 371a7eaa6118763b66d136f44af436fcc2d0ca71 Mon Sep 17 00:00:00 2001
From: gootdude <59850+gootdude@users.noreply.github.com>
Date: Thu, 4 May 2023 03:59:16 -0500
Subject: [PATCH] rds_instance: fix promotion_tier type (#1475)

rds_instance: fix promotion_tier type

SUMMARY

Change promotion_tier type to integer

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

rds_instance.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
---
 .../1475-rds_instance-promotion-tier.yml         |  2 ++
 plugins/modules/rds_instance.py                  | 16 ++++++++--------
 2 files changed, 10 insertions(+), 8 deletions(-)
 create mode 100644 changelogs/fragments/1475-rds_instance-promotion-tier.yml

diff --git a/changelogs/fragments/1475-rds_instance-promotion-tier.yml b/changelogs/fragments/1475-rds_instance-promotion-tier.yml
new file mode 100644
index 00000000000..a7eee21c53b
--- /dev/null
+++ b/changelogs/fragments/1475-rds_instance-promotion-tier.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - rds_instance - fix type of ``promotion_tier`` as passed to the APIs (https://github.com/ansible-collections/amazon.aws/pull/1475).
diff --git a/plugins/modules/rds_instance.py b/plugins/modules/rds_instance.py
index 3c20271cdbe..4e14df3ef18 100644
--- a/plugins/modules/rds_instance.py
+++ b/plugins/modules/rds_instance.py
@@ -336,7 +336,7 @@
         description:
           - An integer that specifies the order in which an Aurora Replica is promoted to the primary instance after a failure of
             the existing primary instance.
-        type: str
+        type: int
     publicly_accessible:
         description:
           - Specifies the accessibility options for the DB instance. A value of true specifies an Internet-facing instance with
@@ -1349,13 +1349,13 @@ def main():
         new_db_instance_identifier=dict(aliases=['new_instance_id', 'new_id']),
         option_group_name=dict(),
         performance_insights_kms_key_id=dict(),
-        performance_insights_retention_period=dict(type='int'),
-        port=dict(type='int'),
-        preferred_backup_window=dict(aliases=['backup_window']),
-        preferred_maintenance_window=dict(aliases=['maintenance_window']),
-        processor_features=dict(type='dict'),
-        promotion_tier=dict(),
-        publicly_accessible=dict(type='bool'),
+        performance_insights_retention_period=dict(type="int"),
+        port=dict(type="int"),
+        preferred_backup_window=dict(aliases=["backup_window"]),
+        preferred_maintenance_window=dict(aliases=["maintenance_window"]),
+        processor_features=dict(type="dict"),
+        promotion_tier=dict(type='int'),
+        publicly_accessible=dict(type="bool"),
         restore_time=dict(),
         s3_bucket_name=dict(),
         s3_ingestion_role_arn=dict(),