Document and validate backup_selection conditions suboptions #1633
Conversation
|
I'm not sure if this is better characterized as a minor change or a bugfix. Let me know if I should change it. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 21s |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 07s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 16s |
Co-authored-by: Jill R <[email protected]>
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 17s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 39s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 50s |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1638 🤖 @patchback |
Document and validate backup_selection conditions suboptions SUMMARY Adds documentation and validation for all conditions suboptions in backup_selection module. Fixes #1613 Additionally fixes a bug in module_utils.backup that caused an empty list to be returned from get_selection_details() when multiple backup selections exist for a given backup plan. ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_selection module_utils.backup ADDITIONAL INFORMATION See #1613 for detailed description of related issue. Reviewed-by: Jill R Reviewed-by: Alina Buzachis (cherry picked from commit cfeffe6)
…1638) [PR #1633/cfeffe66 backport][stable-6] Document and validate backup_selection conditions suboptions This is a backport of PR #1633 as merged into main (cfeffe6). SUMMARY Adds documentation and validation for all conditions suboptions in backup_selection module. Fixes #1613 Additionally fixes a bug in module_utils.backup that caused an empty list to be returned from get_selection_details() when multiple backup selections exist for a given backup plan. ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_selection module_utils.backup ADDITIONAL INFORMATION See #1613 for detailed description of related issue. Reviewed-by: Alina Buzachis
…r auto. (ansible-collections#1633) Addressing Style S3 (ssm_connection) - choose between path, virtual or auto. SUMMARY Added the chance of setting up the addressing style for S3 URLs, this fixes ansible-collections#637 ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION I came across this issue when I was trying to connect and execute tasks on a fresh AWS set-up (new S3 bucket + EC2), I'm using the latest (5.1.0) release and Ansible 5.10 (as per pip show). The issue itself is the same as ansible-collections#637 and the last comment is the fix, there's another PR addressing this issue ansible-collections#786 but is quiet since May Also AWS seems to be deprecating PATH addressing style: https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access Thanks to timburnet-systematica and james-masson for their initial work on this. Reviewed-by: Mark Chappell <None>
SUMMARY
Adds documentation and validation for all
conditionssuboptions in backup_selection module. Fixes #1613Additionally fixes a bug in module_utils.backup that caused an empty list to be returned from get_selection_details() when multiple backup selections exist for a given backup plan.
ISSUE TYPE
COMPONENT NAME
backup_selection
module_utils.backup
ADDITIONAL INFORMATION
See #1613 for detailed description of related issue.