Add ability to remove detached internet gateway #1786
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
branic
force-pushed
the
branic/issue1669
branch
3 times, most recently
from
8b23f42 to
412b2e5
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 50s |
There was a problem hiding this comment.
Thanks for taking the time to submit this PR.
I've had a quick look. The way the documentation's now worded it looks like the module should cope with attaching an existing (unattached) IGW to a VPC, which isn't the case. I think it's worth either adding this feature or rewording the documentation. (This might also help with #1787 since you'd at least be able to use the created IGW)
branic
force-pushed
the
branic/issue1669
branch
2 times, most recently
from
72304c9 to
0366776
Compare
branic
force-pushed
the
branic/issue1669
branch
from
f060225 to
0b9016b
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 32s |
…-collections#1786) aws_config_delivery_channel - Add support for KMS encryption SUMMARY Add support for KMS keys when creating an AWS Config delivery channel ISSUE TYPE Feature Pull Request COMPONENT NAME aws_config_delivery_channel ADDITIONAL INFORMATION AWS added support for KMS encryption of objects stored in S3. This adds that option via a new kms_key_arn module option. Reviewed-by: Mark Chappell
branic
force-pushed
the
branic/issue1669
branch
from
0b9016b to
83cd866
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 15s |
|
@tremble I just wanted to check in and see if you could review this PR again. Thank you. |
branic
force-pushed
the
branic/issue1669
branch
from
83cd866 to
c0b6fce
Compare
|
Thanks @tremble. I totally understand life getting in the way and I appreciate you taking a look at this so quickly today. I've made the requested changes so hopefully all looks good now. If you find anything else that needs to be addressed I'm happy to do so. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 54s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 05s |
|
Pull request merge failed: Required status check "ansible/gate" is expected. |
|
regate |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 14m 07s |
|
Pull request merge failed: Required status check "ansible/gate" is expected. |
Also adds the ability to attach/detach/change VPC of internet gateway Fixes: ansible-collections#1787
tremble
force-pushed
the
branic/issue1669
branch
from
c0b6fce to
7875b4d
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 46s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 04s |
softwarefactory-project-zuul
bot
merged commit 35ea344
into
ansible-collections:main
SUMMARY
Introduces the ability to remove an internet gateway that is not attached to a VPC. To remove an internet gateway either the ID of the internet gateway or the ID of the attached VPC can be supplied. It is also possible to supply both IDs. If both IDs are supplied then a failure will be generated if the attached VPC ID does not match the user supplied VPC.
Fixes #1669
ISSUE TYPE
COMPONENT NAME
ec2_vpc_igw
ADDITIONAL INFORMATION
I wasn't able to add a test for removing an internet gateway that is detached as the module currently doesn't have a way to create a detached internet gateway. I plan on opening a follow-up PR for that use case and will add an appropriate removal test in that PR.