Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_eni - Yet Another Stabilization PR #180

Merged
merged 14 commits into from
Nov 16, 2020

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 23, 2020

SUMMARY

https://app.shippable.com/github/ansible-collections/amazon.aws/runs/885/28/console

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_eni

ADDITIONAL INFORMATION
04:56 TASK [ec2_eni : create a network interface] ************************************
04:58 An exception occurred during task execution. To see the full traceback, use -vvv. The error was: TypeError: argument of type 'NoneType' is not iterable
04:58 fatal: [testhost]: FAILED! => {"changed": false, "module_stderr": "Traceback (most recent call last):\n  File \"/root/.ansible/tmp/ansible-tmp-1603452258.07-1895-100042642436240/AnsiballZ_ec2_eni.py\", line 128, in <module>\n    _ansiballz_main()\n  File \"/root/.ansible/tmp/ansible-tmp-1603452258.07-1895-100042642436240/AnsiballZ_ec2_eni.py\", line 120, in _ansiballz_main\n    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n  File \"/root/.ansible/tmp/ansible-tmp-1603452258.07-1895-100042642436240/AnsiballZ_ec2_eni.py\", line 66, in invoke_module\n    runpy.run_module(mod_name='ansible_collections.amazon.aws.plugins.modules.ec2_eni', init_globals=None, run_name='__main__', alter_sys=True)\n  File \"/usr/lib/python2.7/runpy.py\", line 188, in run_module\n    fname, loader, pkg_name)\n  File \"/usr/lib/python2.7/runpy.py\", line 82, in _run_module_code\n    mod_name, mod_fname, mod_loader, pkg_name)\n  File \"/usr/lib/python2.7/runpy.py\", line 72, in _run_code\n    exec code in run_globals\n  File \"/tmp/ansible_ec2_eni_payload_N2pvfe/ansible_ec2_eni_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_eni.py\", line 853, in <module>\n  File \"/tmp/ansible_ec2_eni_payload_N2pvfe/ansible_ec2_eni_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_eni.py\", line 844, in main\n  File \"/tmp/ansible_ec2_eni_payload_N2pvfe/ansible_ec2_eni_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_eni.py\", line 491, in create_eni\n  File \"/tmp/ansible_ec2_eni_payload_N2pvfe/ansible_ec2_eni_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_eni.py\", line 317, in get_eni_info\nTypeError: argument of type 'NoneType' is not iterable\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}

@tremble tremble force-pushed the ec2_eni/creation_waiter branch 3 times, most recently from e59a8ad to dff0049 Compare October 27, 2020 19:11
@tremble tremble changed the title [WIP] Attempt to add a waiter on ENI creation - try to fix race condion ec2_eni - Yet Another Stabilization PR Oct 27, 2020
@tremble tremble requested a review from jillr October 27, 2020 19:25
@tremble tremble force-pushed the ec2_eni/creation_waiter branch 4 times, most recently from f4f568e to 08282d5 Compare October 30, 2020 20:18
@tremble tremble force-pushed the ec2_eni/creation_waiter branch from 08282d5 to 62eba80 Compare November 12, 2020 08:53
@tremble tremble force-pushed the ec2_eni/creation_waiter branch from 62eba80 to dd0a375 Compare November 16, 2020 15:07
@@ -0,0 +1,3 @@
minor_changes:
- ec2_eni - Improve reliability of the module (https://github.com/ansible-collections/amazon.aws/pull/180).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tremble Nit, the waiters improve stability but can also make the module take longer to return. Can you expand on that in the changelog please?

Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tremble!

@jillr jillr merged commit 23f4246 into ansible-collections:main Nov 16, 2020
@tremble tremble deleted the ec2_eni/creation_waiter branch May 28, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants