Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple decorator for handling common botocore/boto3 errors #1951

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Add simple decorator for handling common botocore/boto3 errors #1951

merged 4 commits into from
Jan 31, 2024

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 15, 2024 •
edited
Loading

SUMMARY

Adds a handler for common IAM API errors

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/iam.py
plugins/modules/iam_user.py

ADDITIONAL INFORMATION

TODO:

  • Changelog

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/16b76fe63e7b478abdbf7bf5fcb75fb6

✔️ ansible-galaxy-importer SUCCESS in 4m 29s
✔️ build-ansible-collection SUCCESS in 13m 58s
✔️ ansible-test-splitter SUCCESS in 5m 14s
✔️ integration-amazon.aws-1 SUCCESS in 15m 18s
✔️ integration-amazon.aws-2 SUCCESS in 6m 35s
✔️ integration-amazon.aws-3 SUCCESS in 8m 28s
✔️ integration-amazon.aws-4 SUCCESS in 8m 49s
✔️ integration-community.aws-1 SUCCESS in 18m 37s
✔️ integration-community.aws-2 SUCCESS in 6m 38s
✔️ integration-community.aws-3 SUCCESS in 6m 58s
Skipped 37 jobs

@tremble tremble force-pushed the complexity/iam_user branch 2 times, most recently from 76d4c72 to 6b546dc Compare January 27, 2024 16:27
@tremble tremble marked this pull request as ready for review January 27, 2024 16:27
@tremble tremble requested a review from alinabuzachis January 27, 2024 16:27
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/efe082e7140349009dfc7caac10fc166

✔️ ansible-galaxy-importer SUCCESS in 4m 31s
✔️ build-ansible-collection SUCCESS in 15m 11s
✔️ ansible-test-splitter SUCCESS in 5m 31s
❌ integration-amazon.aws-1 RETRY_LIMIT in 1m 40s
❌ integration-amazon.aws-2 RETRY_LIMIT in 1m 37s
✔️ integration-amazon.aws-3 SUCCESS in 8m 07s
✔️ integration-amazon.aws-4 SUCCESS in 10m 18s
✔️ integration-community.aws-1 SUCCESS in 17m 44s
✔️ integration-community.aws-2 SUCCESS in 5m 30s
✔️ integration-community.aws-3 SUCCESS in 5m 39s
Skipped 37 jobs

@tremble
Copy link
Contributor Author

tremble commented Jan 29, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5b460e73262c43a88eba46bda3ef4681

✔️ ansible-galaxy-importer SUCCESS in 4m 22s
✔️ build-ansible-collection SUCCESS in 16m 16s
✔️ ansible-test-splitter SUCCESS in 5m 59s
✔️ integration-amazon.aws-1 SUCCESS in 14m 29s
✔️ integration-amazon.aws-2 SUCCESS in 5m 10s
✔️ integration-amazon.aws-3 SUCCESS in 7m 58s
❌ integration-amazon.aws-4 RETRY_LIMIT in 1m 37s
❌ integration-community.aws-1 RETRY_LIMIT in 1m 41s
✔️ integration-community.aws-2 SUCCESS in 5m 37s
❌ integration-community.aws-3 RETRY_LIMIT in 2m 23s
Skipped 37 jobs

@tremble tremble force-pushed the complexity/iam_user branch 4 times, most recently from 091836a to ea769ad Compare January 29, 2024 13:58
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fdaabd2d2cff4bbd97348cddd680d9dc

✔️ ansible-galaxy-importer SUCCESS in 4m 20s
✔️ build-ansible-collection SUCCESS in 16m 16s
✔️ ansible-test-splitter SUCCESS in 5m 51s
✔️ integration-amazon.aws-1 SUCCESS in 13m 09s
✔️ integration-amazon.aws-2 SUCCESS in 6m 38s
✔️ integration-amazon.aws-3 SUCCESS in 8m 08s
✔️ integration-amazon.aws-4 SUCCESS in 8m 53s
✔️ integration-community.aws-1 SUCCESS in 19m 43s
✔️ integration-community.aws-2 SUCCESS in 5m 24s
✔️ integration-community.aws-3 SUCCESS in 7m 09s
Skipped 37 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6474c7df2bc54467a9e9f9f60dc48dc6

✔️ ansible-galaxy-importer SUCCESS in 4m 17s
✔️ build-ansible-collection SUCCESS in 15m 18s
✔️ ansible-test-splitter SUCCESS in 5m 27s
✔️ integration-amazon.aws-1 SUCCESS in 12m 39s
✔️ integration-amazon.aws-2 SUCCESS in 5m 09s
✔️ integration-amazon.aws-3 SUCCESS in 9m 42s
✔️ integration-amazon.aws-4 SUCCESS in 10m 49s
✔️ integration-community.aws-1 SUCCESS in 21m 04s
✔️ integration-community.aws-2 SUCCESS in 10m 15s
✔️ integration-community.aws-3 SUCCESS in 9m 11s
Skipped 37 jobs

@tremble tremble force-pushed the complexity/iam_user branch from 76261f4 to 7605e51 Compare January 30, 2024 10:07
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/63482942b3ce4238b1a7eef6265d9e2e

✔️ ansible-galaxy-importer SUCCESS in 3m 51s
✔️ build-ansible-collection SUCCESS in 14m 46s
✔️ ansible-test-splitter SUCCESS in 5m 17s
✔️ integration-amazon.aws-1 SUCCESS in 13m 57s
✔️ integration-amazon.aws-2 SUCCESS in 8m 04s
✔️ integration-amazon.aws-3 SUCCESS in 7m 39s
✔️ integration-amazon.aws-4 SUCCESS in 10m 49s
✔️ integration-community.aws-1 SUCCESS in 20m 19s
✔️ integration-community.aws-2 SUCCESS in 8m 07s
✔️ integration-community.aws-3 SUCCESS in 5m 32s
Skipped 37 jobs

@tremble tremble requested review from hakbailey and abikouo January 31, 2024 08:54
@tremble tremble added the backport-7 PR should be backported to the stable-7 branch label Jan 31, 2024
@tremble tremble force-pushed the complexity/iam_user branch from 7605e51 to 07321e7 Compare January 31, 2024 15:45
@tremble tremble requested a review from hakbailey January 31, 2024 15:46
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c51a02fb343e4ef486a8a7755b52fdbb

✔️ ansible-galaxy-importer SUCCESS in 5m 10s
✔️ build-ansible-collection SUCCESS in 15m 11s
✔️ ansible-test-splitter SUCCESS in 5m 30s
✔️ integration-amazon.aws-1 SUCCESS in 15m 00s
✔️ integration-amazon.aws-2 SUCCESS in 8m 34s
✔️ integration-amazon.aws-3 SUCCESS in 9m 22s
✔️ integration-amazon.aws-4 SUCCESS in 11m 48s
✔️ integration-community.aws-1 SUCCESS in 21m 00s
✔️ integration-community.aws-2 SUCCESS in 9m 22s
✔️ integration-community.aws-3 SUCCESS in 8m 59s
Skipped 37 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 31, 2024
@tremble tremble changed the title Add simple handler for common IAM errors Add simple handler decorator for common botocore/boto3 errors Jan 31, 2024
@tremble tremble changed the title Add simple handler decorator for common botocore/boto3 errors Add simple decorator for handling common botocore/boto3 errors Jan 31, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0e81f93027ed47b2b33728b887c01a2d

✔️ ansible-galaxy-importer SUCCESS in 3m 51s
✔️ build-ansible-collection SUCCESS in 15m 04s
✔️ ansible-test-splitter SUCCESS in 6m 06s
✔️ integration-amazon.aws-1 SUCCESS in 13m 10s
✔️ integration-amazon.aws-2 SUCCESS in 6m 34s
✔️ integration-amazon.aws-3 SUCCESS in 7m 48s
✔️ integration-amazon.aws-4 SUCCESS in 8m 38s
✔️ integration-community.aws-1 SUCCESS in 16m 44s
✔️ integration-community.aws-2 SUCCESS in 6m 37s
✔️ integration-community.aws-3 SUCCESS in 5m 28s
Skipped 37 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 655a9dd into ansible-collections:main Jan 31, 2024
37 of 40 checks passed
@patchback Patchback
Copy link

patchback bot commented Jan 31, 2024 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/655a9dd134810570f33a93513c979d5b84581e77/pr-1951

Backported as #1960

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 31, 2024
@tremble @patchback
Add simple decorator for handling common botocore/boto3 errors (#1951)
6c124a2 
Add simple decorator for handling common botocore/boto3 errors

SUMMARY
Adds a handler for common IAM API errors
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/iam.py
plugins/modules/iam_user.py
ADDITIONAL INFORMATION
TODO:

  Changelog

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
Reviewed-by: Bikouo Aubin
Reviewed-by: Helen Bailey <[email protected]>
(cherry picked from commit 655a9dd)
@patchback patchback bot mentioned this pull request Jan 31, 2024
Merged
1 task
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 31, 2024
@patchback
Add simple decorator for handling common botocore/boto3 errors (#1951) (
6afbd73 
#1960)

[PR #1951/655a9dd1 backport][stable-7] Add simple decorator for handling common botocore/boto3 errors

This is a backport of PR #1951 as merged into main (655a9dd).
SUMMARY
Adds a handler for common IAM API errors
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/iam.py
plugins/modules/iam_user.py
ADDITIONAL INFORMATION
TODO:

  Changelog

Reviewed-by: Mark Chappell
@tremble tremble deleted the complexity/iam_user branch February 21, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo abikouo approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@hakbailey hakbailey hakbailey approved these changes

Assignees
No one assigned
Labels
backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tremble @hakbailey @alinabuzachis @abikouo