Refactor ec2_nat_gateway*, ec2_vpc_igw*, ec2_snapshot*, ec2_spot_instance* #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
abikouo
changed the title
Closed
hakbailey
reviewed
May 24, 2024
|
recheck |
hakbailey
reviewed
Jun 5, 2024
|
recheck |
|
recheck |
GomathiselviS
approved these changes
Jun 13, 2024
|
regate |
|
recheck |
hakbailey
approved these changes
Jun 18, 2024
|
regate |
|
regate |
softwarefactory-project-zuul
bot
merged commit 2643289
into
ansible-collections:main
38 of 39 checks passed
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jun 26, 2024
…ance* (ansible-collections#2099) SUMMARY This pull request contains a set of changes: module_utils/ec2.py: add a set of AWS API wrapped into retry and AnsibleEC2ErrorHandler, some of them will be used later to refactor others ec2_* modules Refactorec2_vol*, ec2_nat_gateway*, ec2_vpc_igw*, ec2_snapshot*, ec2_spot_instance* modules: add type hint, the main() function should be limited to call either ensure_[absent|present] functions or any others function to describe resources. The changes in this PR have been extracted from ansible-collections#2076 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_snapshot ec2_snapshot_info ec2_spot_instance ec2_spot_instance_info ec2_vol ec2_vol_info ec2_vpc_igw ec2_vpc_igw_info ec2_vpc_nat_gateway ec2_vpc_nat_gateway_info ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pull request contains a set of changes:
The changes in this PR have been extracted from #2076
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION