Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ec2_vpc_subnet* modules #2160

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Refactor ec2_vpc_subnet* modules #2160

merged 5 commits into from
Jul 8, 2024

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jul 1, 2024 •
edited
Loading

SUMMARY

Refactor ec2_vpc_subnet* modules

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • ec2_vpc_subnet
  • ec2_vpc_subnet_info

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/66c536b0a1c741efbf006053c1ccca68

✔️ ansible-galaxy-importer SUCCESS in 4m 54s
✔️ build-ansible-collection SUCCESS in 12m 39s
✔️ ansible-test-splitter SUCCESS in 5m 05s
✔️ integration-amazon.aws-1 SUCCESS in 6m 34s
Skipped 43 jobs

GomathiselviS
GomathiselviS approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@GomathiselviS GomathiselviS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for the minor comment.

plugins/modules/ec2_vpc_subnet.py Outdated Show resolved Hide resolved
@abikouo abikouo force-pushed the refactor_ec2_vpc_subnet_2401071331 branch from 4e29f93 to 973751e Compare July 5, 2024 13:47
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/9a46cfc2a8e64fd7a3616c7d956c399c

✔️ ansible-galaxy-importer SUCCESS in 5m 02s
✔️ build-ansible-collection SUCCESS in 12m 22s
✔️ ansible-test-splitter SUCCESS in 4m 58s
✔️ integration-amazon.aws-1 SUCCESS in 7m 01s
Skipped 43 jobs

alinabuzachis
alinabuzachis approved these changes Jul 5, 2024
View reviewed changes
plugins/modules/ec2_vpc_subnet.py Outdated Show resolved Hide resolved
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9f69d1eb72e54ff3b6c4bc9a7fc732cc

✔️ ansible-galaxy-importer SUCCESS in 4m 31s
✔️ build-ansible-collection SUCCESS in 12m 11s
✔️ ansible-test-splitter SUCCESS in 4m 56s
❌ integration-amazon.aws-1 FAILURE in 5m 04s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e534f97f413948159f1131d2fa9f4afb

✔️ ansible-galaxy-importer SUCCESS in 4m 44s
✔️ build-ansible-collection SUCCESS in 12m 35s
✔️ ansible-test-splitter SUCCESS in 5m 07s
✔️ integration-amazon.aws-1 SUCCESS in 6m 23s
Skipped 43 jobs

@abikouo abikouo force-pushed the refactor_ec2_vpc_subnet_2401071331 branch from 0eb8421 to c775914 Compare July 8, 2024 14:02
@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Jul 8, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/d24342e75f80467d8bc4524919ab8912

✔️ ansible-galaxy-importer SUCCESS in 3m 45s
✔️ build-ansible-collection SUCCESS in 12m 48s
✔️ ansible-test-splitter SUCCESS in 5m 05s
✔️ integration-amazon.aws-1 SUCCESS in 5m 37s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f22da70 into ansible-collections:main Jul 8, 2024
31 of 36 checks passed
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 16, 2024
@alinabuzachis
Refactor ec2_vpc_vpn* modules (ansible-collections#2160)
7cdd0a0 
SUMMARY

Refactor ec2_vpc_vpn* modules

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_vpc_vpn
ec2_vpc_vpn_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@d2403ab
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Oct 24, 2024
@alinabuzachis
Refactor ec2_vpc_vpn* modules (ansible-collections#2160)
d46af7e 
SUMMARY

Refactor ec2_vpc_vpn* modules

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ec2_vpc_vpn
ec2_vpc_vpn_info
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS <[email protected]>
Reviewed-by: Bikouo Aubin

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@d2403ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GomathiselviS GomathiselviS GomathiselviS approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abikouo @alinabuzachis @GomathiselviS