Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module cloudwatch_metric_alarm support DatapointsToAlarm config #2196

Merged
merged 1 commit into from
Aug 28, 2024
Merged

module cloudwatch_metric_alarm support DatapointsToAlarm config #2196

merged 1 commit into from
Aug 28, 2024

Conversation

owanio1992
Copy link
Contributor

SUMMARY

module cloudwatch_metric_alarm support DatapointsToAlarm config #2193

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

cloudwatch_metric_alarm

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c61c7460e7364093b8420909cdabb3c4

✔️ ansible-galaxy-importer SUCCESS in 4m 04s
✔️ build-ansible-collection SUCCESS in 12m 29s
✔️ ansible-test-splitter SUCCESS in 4m 57s
✔️ integration-amazon.aws-1 SUCCESS in 7m 59s
Skipped 43 jobs

@alinabuzachis
Copy link
Collaborator

@owanio1992 Thank you for working on this new feature. Can you please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment and cover this functionality with tests?

@owanio1992 owanio1992 force-pushed the cloudwatch_metric_alarm/DatapointsToAlarm branch from 2c10f81 to d74331b Compare July 18, 2024 14:59
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/35c32e9b802b47719c1648c7e7d9c3a3

✔️ ansible-galaxy-importer SUCCESS in 4m 27s
✔️ build-ansible-collection SUCCESS in 12m 56s
✔️ ansible-test-splitter SUCCESS in 5m 09s
✔️ integration-amazon.aws-1 SUCCESS in 8m 12s
Skipped 43 jobs

@owanio1992 owanio1992 force-pushed the cloudwatch_metric_alarm/DatapointsToAlarm branch from d74331b to d6d1037 Compare July 29, 2024 05:11
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/62af1653154544a3991f2798b89dc14c

✔️ ansible-galaxy-importer SUCCESS in 4m 52s
✔️ build-ansible-collection SUCCESS in 10m 26s
✔️ ansible-test-splitter SUCCESS in 4m 16s
✔️ integration-amazon.aws-1 SUCCESS in 8m 03s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b8f88f1d079a451a8e7a8f2c3e4390cf

✔️ ansible-galaxy-importer SUCCESS in 5m 09s
✔️ build-ansible-collection SUCCESS in 10m 26s
✔️ ansible-test-splitter SUCCESS in 4m 16s
✔️ integration-amazon.aws-1 SUCCESS in 7m 22s
Skipped 43 jobs

@alinabuzachis
Copy link
Collaborator

@owanio1992 Can you please rebase? It LGTM. Thank you.

@alinabuzachis alinabuzachis added the backport-8 PR should be backported to the stable-8 branch label Aug 22, 2024
@alinabuzachis alinabuzachis requested a review from tremble August 22, 2024 17:28
@alinabuzachis alinabuzachis added this to the 8.2.0 milestone Aug 22, 2024
@owanio1992
Copy link
Contributor Author

@alinabuzachis rebase done. thank you

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fc9e2040d36e472a97fa13a40bcb2af5

✔️ ansible-galaxy-importer SUCCESS in 4m 19s
✔️ build-ansible-collection SUCCESS in 10m 32s
✔️ ansible-test-splitter SUCCESS in 4m 16s
✔️ integration-amazon.aws-1 SUCCESS in 10m 42s
Skipped 43 jobs

tremble
tremble approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to submit this PR.

One thing for future PRs: Generally the existing tasks in the integration tests shouldn't be modified, and net-new tasks should be added instead. This helps to ensure that the module changes don't break existing playbooks unless the change has been explicitly marked as a "breaking" change.

@tremble tremble force-pushed the cloudwatch_metric_alarm/DatapointsToAlarm branch from 6b6a4cd to 2c12f64 Compare August 28, 2024 07:49
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Aug 28, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/3d7eb6e3f44a488a85878425d8806bc9

✔️ ansible-galaxy-importer SUCCESS in 4m 44s
✔️ build-ansible-collection SUCCESS in 10m 59s
✔️ ansible-test-splitter SUCCESS in 4m 21s
✔️ integration-amazon.aws-1 SUCCESS in 8m 02s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f003163 into ansible-collections:main Aug 28, 2024
21 of 37 checks passed
@patchback Patchback

This comment was marked as outdated.

Sign in to view
@tremble tremble added backport_failed Backport failed, needs review backport-8 PR should be backported to the stable-8 branch and removed backport-8 PR should be backported to the stable-8 branch backport_failed Backport failed, needs review labels Aug 28, 2024
@patchback Patchback

This comment was marked as outdated.

Sign in to view
@tremble tremble added backport_failed Backport failed, needs review and removed backport-8 PR should be backported to the stable-8 branch labels Aug 28, 2024
@tremble tremble added the backport-8 PR should be backported to the stable-8 branch label Aug 28, 2024
@patchback Patchback

This comment was marked as resolved.

Sign in to view
@tremble tremble added backport-8 PR should be backported to the stable-8 branch and removed backport-8 PR should be backported to the stable-8 branch labels Aug 28, 2024
@patchback Patchback
Copy link

patchback bot commented Aug 28, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/f0031630257ffeb107ada6108fa1e974a6301c63/pr-2196

Backported as #2257

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 28, 2024
@owanio1992 @patchback
module cloudwatch_metric_alarm support DatapointsToAlarm config (#2196)
50aec30 
SUMMARY
module cloudwatch_metric_alarm support DatapointsToAlarm config #2193
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
cloudwatch_metric_alarm

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
(cherry picked from commit f003163)
@patchback patchback bot mentioned this pull request Aug 28, 2024
Merged
@tremble tremble removed the backport_failed Backport failed, needs review label Aug 28, 2024
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 28, 2024
@patchback
module cloudwatch_metric_alarm support DatapointsToAlarm config (#2196)…
bb90676 
… (#2257)

This is a backport of PR #2196 as merged into main (f003163).
SUMMARY
module cloudwatch_metric_alarm support DatapointsToAlarm config #2193
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
cloudwatch_metric_alarm

Reviewed-by: Mark Chappell
braydencw1 pushed a commit to braydencw1/amazon.aws that referenced this pull request Aug 29, 2024
@owanio1992 @braydencw1
module cloudwatch_metric_alarm support DatapointsToAlarm config (ansi…
87f2342 
…ble-collections#2196)

SUMMARY
module cloudwatch_metric_alarm support DatapointsToAlarm config ansible-collections#2193
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
cloudwatch_metric_alarm

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
backport-8 PR should be backported to the stable-8 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@owanio1992 @alinabuzachis @tremble