iam_role - Deprecate creating/deleting instance profiles through iam_role #2221
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 47s |
tremble
force-pushed
the
iam_role/drop_profile_management
branch
from
219cf7a to
7f05b27
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 19s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 32s |
softwarefactory-project-zuul
bot
merged commit 7227664
into
ansible-collections:main
This comment was marked as resolved.
This comment was marked as resolved.
tremble
added
backport-8
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #2232 🤖 @patchback |
SUMMARY Before the addition of iam_instance_profile the only way to create instance profiles was through iam_role. We now have a dedicated module. With the principle of "do one thing and do it well", let's formally deprecate support for creating/deleting instance profiles from the iam_role module. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION There's also some kind of issue around profiles already existing (see #2102 ) Reviewed-by: Alina Buzachis (cherry picked from commit 7227664)
…) (#2232) This is a backport of PR #2221 as merged into main (7227664). SUMMARY Before the addition of iam_instance_profile the only way to create instance profiles was through iam_role. We now have a dedicated module. With the principle of "do one thing and do it well", let's formally deprecate support for creating/deleting instance profiles from the iam_role module. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION There's also some kind of issue around profiles already existing (see #2102 ) Reviewed-by: Mark Chappell
…ible-collections#2221) SUMMARY Before the addition of iam_instance_profile the only way to create instance profiles was through iam_role. We now have a dedicated module. With the principle of "do one thing and do it well", let's formally deprecate support for creating/deleting instance profiles from the iam_role module. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION There's also some kind of issue around profiles already existing (see ansible-collections#2102 ) Reviewed-by: Alina Buzachis
…en not creating a profile (#2282) fixes: #2102 fixes: #2281 SUMMARY #2221 deprecation logic accidentally forced create_instance_profile to True The IAM refactor made iam_role sensitive to pre-existing instance profiles with the same name. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: GomathiselviS
…en not creating a profile (#2282) fixes: #2102 fixes: #2281 SUMMARY #2221 deprecation logic accidentally forced create_instance_profile to True The IAM refactor made iam_role sensitive to pre-existing instance profiles with the same name. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: GomathiselviS (cherry picked from commit 4867e68)
…en not creating a profile (#2282) (#2283) This is a backport of PR #2282 as merged into main (4867e68). fixes: #2102 fixes: #2281 SUMMARY #2221 deprecation logic accidentally forced create_instance_profile to True The IAM refactor made iam_role sensitive to pre-existing instance profiles with the same name. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
SUMMARY
Before the addition of iam_instance_profile the only way to create instance profiles was through iam_role. We now have a dedicated module. With the principle of "do one thing and do it well", let's formally deprecate support for creating/deleting instance profiles from the iam_role module.
ISSUE TYPE
COMPONENT NAME
iam_role
ADDITIONAL INFORMATION
There's also some kind of issue around profiles already existing (see #2102 )