Add utils for ec2_placement_group #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abikouo
requested changes
Oct 4, 2024
alinabuzachis
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
I'm not sure if it makes sense to use DryRun. I would probably use check_mode without passing DryRun, but I would also like to know what @tremble thinks about.
abikouo
requested changes
Oct 9, 2024
I've currently removed it. From my assessment based on the definition of check_mode, the API should not be invoked at all. Moreover, DryRun is utilized across various AWS APIs beyond just placement groups. Given that other modules haven't implemented it, it seemed logical to exclude the DryRun functionality from this particular module. |
abikouo
approved these changes
Oct 11, 2024
GomathiselviS
force-pushed
the
palcement_grp
branch
from
f1b7cf8 to
b2fd10d
Compare
Co-authored-by: Bikouo Aubin <[email protected]>
GomathiselviS
force-pushed
the
palcement_grp
branch
from
b2fd10d to
b599b6e
Compare
softwarefactory-project-zuul
bot
merged commit 04a2ffb
into
ansible-collections:main
36 checks passed
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Oct 16, 2024
SUMMARY This PR refactors ec2_placement_group*. Depends-On: ansible-collections/amazon.aws#2322 Refer: https://issues.redhat.com/browse/ACA-1886 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis
GomathiselviS
added a commit
that referenced
this pull request
Oct 17, 2024
SUMMARY This PR refactors ec2_placement_group*. Depends-On: #2322 Refer: https://issues.redhat.com/browse/ACA-1886 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@290e89a
alinabuzachis
pushed a commit
to GomathiselviS/community.aws
that referenced
this pull request
Oct 17, 2024
…s#2167) SUMMARY This PR refactors ec2_placement_group*. Depends-On: ansible-collections/amazon.aws#2322 Refer: https://issues.redhat.com/browse/ACA-1886 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis
GomathiselviS
added a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Oct 17, 2024
…s#2167) SUMMARY This PR refactors ec2_placement_group*. Depends-On: ansible-collections#2322 Refer: https://issues.redhat.com/browse/ACA-1886 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@290e89a
GomathiselviS
added a commit
that referenced
this pull request
Oct 17, 2024
SUMMARY This PR refactors ec2_placement_group*. Depends-On: #2322 Refer: https://issues.redhat.com/browse/ACA-1886 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@290e89a
GomathiselviS
added a commit
to GomathiselviS/amazon.aws
that referenced
this pull request
Oct 24, 2024
…s#2167) SUMMARY This PR refactors ec2_placement_group*. Depends-On: ansible-collections#2322 Refer: https://issues.redhat.com/browse/ACA-1886 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@290e89a
alinabuzachis
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2024
…s#2167) SUMMARY This PR refactors ec2_placement_group*. Depends-On: ansible-collections/amazon.aws#2322 Refer: https://issues.redhat.com/browse/ACA-1886 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds utils for ec2_placement_group
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION