Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudformation: Fix bug when updating stack's termination_protection with create_changeset set #2391

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mandar242
Copy link
Contributor

@mandar242 mandar242 commented Nov 15, 2024

SUMMARY

Fixes #2149
Fix bug where termination protection is not updated when create_changeset=true is used for stack updates

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloudformation

ADDITIONAL INFORMATION

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2e5df5c2dddd43669e7bddc7aff0dae1

✔️ ansible-galaxy-importer SUCCESS in 5m 34s
✔️ build-ansible-collection SUCCESS in 10m 11s
✔️ ansible-test-splitter SUCCESS in 3m 53s
✔️ integration-amazon.aws-1 SUCCESS in 15m 26s
Skipped 43 jobs

Copy link
Contributor

@hakbailey hakbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add an integration test for this case?

Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
Just missing integration tests

@mandar242 mandar242 force-pushed the cloudformation-bug-fix branch from d9a6377 to 72b3833 Compare December 11, 2024 18:04
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/345cee546d4442ad838629646d1596fe

✔️ ansible-galaxy-importer SUCCESS in 6m 53s
✔️ build-ansible-collection SUCCESS in 10m 19s
✔️ ansible-test-splitter SUCCESS in 4m 10s
✔️ integration-amazon.aws-1 SUCCESS in 14m 19s
Skipped 43 jobs

@mandar242 mandar242 requested a review from hakbailey December 11, 2024 19:40
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/002364d33ab24f4bb24bf8eefd46b27c

✔️ ansible-galaxy-importer SUCCESS in 5m 38s
✔️ build-ansible-collection SUCCESS in 10m 10s
✔️ ansible-test-splitter SUCCESS in 3m 55s
integration-amazon.aws-1 FAILURE in 6m 27s
Skipped 43 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c002f9072a9145e291a05c7276b88a25

✔️ ansible-galaxy-importer SUCCESS in 5m 05s
✔️ build-ansible-collection SUCCESS in 10m 50s
✔️ ansible-test-splitter SUCCESS in 3m 55s
✔️ integration-amazon.aws-1 SUCCESS in 16m 58s
Skipped 43 jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Termination Protection is not Enabled for Existing Stacks when Create Change Set is Enabled
4 participants