-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudformation: Fix bug when updating stack's termination_protection with create_changeset set #2391
base: main
Are you sure you want to change the base?
cloudformation: Fix bug when updating stack's termination_protection with create_changeset set #2391
Conversation
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 34s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add an integration test for this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Just missing integration tests
d9a6377
to
72b3833
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 6m 53s |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 38s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 05s |
SUMMARY
Fixes #2149
Fix bug where termination protection is not updated when create_changeset=true is used for stack updates
ISSUE TYPE
COMPONENT NAME
cloudformation
ADDITIONAL INFORMATION