new helper function : normalize_boto3_result #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
|
@jillr Stealing the logic from multiple community modules (because I need it in yet another one):
Before I sit down and write unit tests, any objections? |
tremble
changed the title
tremble
changed the title
|
@tremble I like the idea of this, I've run across it several times recently myself. I see the unit test but wanted to be sure that's what your previous comment referred to - is this one ready? |
|
This is ready for review. I initially pushed this before my first absence this month and wanted to get your opinion on pulling this code into module_utils. Decided to just get the unit tests written in the end. They're not 100% comprehensive, but they can be expanded if we find gaps. |
jillr
approved these changes
Mar 10, 2021
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Ansible 2.9 has a test constraint for openshift >= 0.6.2, < 0.9.0. We're only specifying a minimum boto3 today and 1.16.x has released, which pulls in a newer urllib3 than that openshift supports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We have a number of modules using JSON round-tripping to convert dates into ISO-formatted strings. Move this into a common helper.
Right now this only does something unusual to datetime resources, but it's been left generic in case something else is needed (Booleans?)
Todo:
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/core.py
ADDITIONAL INFORMATION