Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity test cleanup (non-breaking) #291

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Mar 6, 2021

SUMMARY

Fixup sanity tests (split from #287)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/cloud.py
plugins/module_utils/cloudfront_facts.py

ADDITIONAL INFORMATION

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module_utils module_utils needs_triage plugins plugin (any type) tests tests labels Mar 6, 2021
@tremble tremble force-pushed the sanity/2021-03-06-non-breaking branch from 8c111ae to fe596b8 Compare March 6, 2021 10:23
@tremble
Copy link
Contributor Author

tremble commented Mar 6, 2021

Test failures were known flakes:

  • DHCP Options (boto v2)
  • connect_to_aws (Amazon getting grumpy due to too multiple failed logins)

@jillr jillr merged commit 8bff512 into ansible-collections:main Mar 9, 2021
@tremble tremble deleted the sanity/2021-03-06-non-breaking branch May 28, 2021 07:08
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review module_utils module_utils needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants