Update the default module requirements from python-2.6/boto to python-3.6/botocore-1.16 (breaking change) #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jillr in your presentation I think you suggested dropping 2.7 support as a part of the 2.0.0 release since boto3 is going to drop support soon. If we're going to do that I guess we update the python requirement in here to 3.6 rather than 2.7. |
|
recheck |
|
@tremble Yeah 1.5 will be the last 2.x supporting release, so we can bump this to py3.6 for collection version 2.0 |
ansibullbot
added
needs_rebase
tremble
force-pushed
the
docs/require-boto3
branch
from
8c9518d to
a123e26
Compare
ansibullbot
added
community_review
and removed
needs_rebase
tremble
changed the title
tremble
force-pushed
the
docs/require-boto3
branch
2 times, most recently
from
b07bd5c to
38d10ac
Compare
tremble
changed the title
tremble
force-pushed
the
docs/require-boto3
branch
from
38d10ac to
66b6f0f
Compare
tremble
changed the title
|
@jillr I don't currently have a PR lined up for community.aws but I can get that lined up in the next couple of days, was mostly waiting on this to land (and decisions from your side on version support policies) I've also added botocore >= 1.16.0 based on the policy in ansible/ansible#74585 (in theory we could bump this to something around 1.16.5 or even 1.17.0 but now there's a general policy outlined I'd be inclined to go slightly older (and with .0 release) knowing we can bump it with the next 'major' release. |
tremble
force-pushed
the
docs/require-boto3
branch
from
5a4d7bf to
aacc85c
Compare
|
recheck |
tremble
force-pushed
the
docs/require-boto3
branch
from
aacc85c to
ffa10d3
Compare
ansible-zuul bot
added a commit
to ansible-collections/community.aws
that referenced
this pull request
Jul 5, 2021
Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 15, 2021
…s/require-boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@f186c9a
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…s/require-boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@f186c9a
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 17, 2021
…s/require-boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@3692d16
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections/amazon.aws#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…boto3 Update the default module requirements from python 2.6/boto to python 3.6/boto3 SUMMARY The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment. Switch the defaults over to reduce the copy&paste and reflect that boto v2 is deprecated python 2.6 is no longer supported by the AWS collections ISSUE TYPE Docs Pull Request COMPONENT NAME lots of them ADDITIONAL INFORMATION Depends-On: ansible-collections#298 Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #302
SUMMARY
The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment.
Switch the defaults over to reduce the copy&paste and reflect that
ISSUE TYPE
COMPONENT NAME
plugins/doc_fragments/aws.py
ADDITIONAL INFORMATION
Should wait for the 2.0 release so we can cleanly update everything.