Add permission to upload ACL in ExtraArgs #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
docs
module
goneri
requested changes
Apr 7, 2021
|
@cbcoutinho Thank you for your contribution. Could you kindly include a functional test and a changelog? Thanks. |
tremble
requested changes
Apr 7, 2021
There was a problem hiding this comment.
The change looks sane, 3 minor issues:
- Please add a changelog fragment (https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to)
- To ensure your docs change isn't automatically overwritten please update the docs at the start of the module (the .rst is auto generated)
- To reduce the risk of a regression being introduced please add an integration test entry (tests/integration/targets/aws_s3/tasks/main.yml). You'll need to update the bucket policy and then upload using the new features.
@alinabuzachis How do you recommend testing this functionality? Is it possible to mock S3 bucket ACLs or do you have to supply S3 credentials and test against existing infra? |
We have a set of integration tests which are just Ansible roles which will be run in CI (tests/integration/targets/aws_s3/tasks/main.yml) temporary credentials will be automatically supplied (see the module_defaults at the start of the yaml file) |
This reverts commit f00cb89.
tremble
reviewed
Apr 7, 2021
tremble
reviewed
Apr 7, 2021
|
@tremble I'm a little unclear exactly how to test this, and I'm having trouble understanding the testing framework here. Is it possible to specify the IAM role used during the PUT operation? Ideally, I would want to XFAIL a test that uses the wrong I'm assuming the credentials used to create the bucket are the same used to do the uploading, which is not the scenario I'm trying to address. |
|
Setting this PR as a draft to denote WIP |
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 19, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 19, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 19, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 19, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 19, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 19, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jul 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
Jul 27, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
Aug 20, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
Aug 26, 2021
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d6ff623
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
* import order * Add retry decorators * Switch tests to using module_defaults * module_defaults * Add initial _info tests * Handle Boto Errors with fail_json_aws * Test state=absent when IGW missing * Support not purging tags * Support converting Tags from boto to dict * Add tagging tests * Use random CIDR for VPC * Add check_mode tests * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the permission ACL when uploading objects (fixes #219)