Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volume tags key with empty dict and test #383

Merged
merged 3 commits into from
Jun 5, 2021
Merged

Add volume tags key with empty dict and test #383

merged 3 commits into from
Jun 5, 2021

Conversation

srirachanaachyuthuni
Copy link
Contributor

@srirachanaachyuthuni srirachanaachyuthuni commented Jun 2, 2021 •
edited
Loading

SUMMARY

Added 'Tags' key to the dictionary describing volume if isn't present
Fixes: #373

ISSUE TYPE
COMPONENT NAME

ec2_snapshot

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @jillr @s-hertel @tremble @willthames @wimnat
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress bug This issue/PR relates to a bug integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jun 2, 2021
jillr
jillr approved these changes Jun 3, 2021
View reviewed changes
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (looks good to me!)

If this PR is ready for review and merging, can you please edit the subject to no longer say WIP?
You can also edit the body of the PR to include a line like:
Fixes: #373
and our github bot will automatically close that bug report when this PR merges. Here's an example PR: #370

@alinabuzachis could you also please review this patch?

@srirachanaachyuthuni srirachanaachyuthuni changed the title WIP: Add volume tags key with empty dict and test Add volume tags key with empty dict and test Jun 3, 2021
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Jun 3, 2021
alinabuzachis
alinabuzachis reviewed Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srirachanaachyuthuni Thank you for your contribution. The PR looks good to me. I left two comments. Can you please include a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs?

tests/integration/targets/ec2_snapshot/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/ec2_snapshot/tasks/main.yml Outdated Show resolved Hide resolved
@jillr
Copy link
Collaborator

jillr commented Jun 4, 2021

Thanks @alinabuzachis, I missed the changelog!!

@alinabuzachis alinabuzachis self-requested a review June 4, 2021 19:13
alinabuzachis
alinabuzachis approved these changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @srirachanaachyuthuni. LGTM.

@jillr jillr added the gate label Jun 4, 2021
@jillr
Copy link
Collaborator

jillr commented Jun 4, 2021

recheck

@jillr
Copy link
Collaborator

jillr commented Jun 4, 2021

Gate test failures are known flakes #382

@jillr
Copy link
Collaborator

jillr commented Jun 4, 2021

recheck

@jillr jillr removed the gate label Jun 4, 2021
@jillr
Copy link
Collaborator

jillr commented Jun 4, 2021

recheck

1 similar comment
@jillr
Copy link
Collaborator

jillr commented Jun 4, 2021

recheck

@jillr jillr added gate and removed gate labels Jun 4, 2021
@jillr jillr added gate and removed gate labels Jun 4, 2021
@ansible-zuul ansible-zuul bot merged commit 0cdc47b into ansible-collections:main Jun 5, 2021
@srirachanaachyuthuni srirachanaachyuthuni deleted the 373_ec2_snapshot_tags branch June 16, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ec2_snapshot tagging fails on KeyError
4 participants
@srirachanaachyuthuni @ansibullbot @jillr @alinabuzachis