Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper for generating TagSpecification lists and update ec2_instance to use helpers #527

Merged
merged 6 commits into from
Oct 6, 2021
Merged

Add helper for generating TagSpecification lists and update ec2_instance to use helpers #527

merged 6 commits into from
Oct 6, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 5, 2021

SUMMARY
  • Moves generic tagging tools into dedicated module_utils.tagging (ensure_ec2_tags is currently EC2 specific and needs some thought to make it more generic)
  • Adds boto3_tag_specifications helper to generate TagSpecification lists
  • Migrates ec2_instance to the new helper and the ensure_ec2_tags helper.
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_instance
plugins/module_utils/ec2.py

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @jillr @ryansb @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module module_utils module_utils needs_triage new_plugin New plugin plugins plugin (any type) tests tests labels Oct 5, 2021
@tremble tremble requested a review from alinabuzachis October 5, 2021 09:37
@tremble
Copy link
Contributor Author

tremble commented Oct 5, 2021

@alinabuzachis One helper, as discussed...

@tremble tremble requested a review from felixfontein October 5, 2021 09:38
@tremble tremble force-pushed the helpers/tagging-specs branch from 108922a to 4a37e12 Compare October 5, 2021 10:51
@jillr jillr removed the needs_triage label Oct 5, 2021
@tremble tremble added the gate label Oct 6, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 28a7227 into ansible-collections:main Oct 6, 2021
@tremble tremble deleted the helpers/tagging-specs branch November 26, 2021 12:42
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@Akasurde
Added ignore-2.12.txt (ansible-collections#527)
395e02b 
* Added ignore-2.12.txt

Signed-off-by: Abhijeet Kasurde <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@felixfontein felixfontein Awaiting requested review from felixfontein

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request module_utils module_utils module module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tremble @ansibullbot @alinabuzachis @jillr