Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard to credentials file in .gitignore #569

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

jillr
Copy link
Collaborator

@jillr jillr commented Nov 15, 2021

SUMMARY

In addition to the static cloud-config-aws.(ini|yml) files devs can create, ansible-test may also create temporary credentials files with random strings in the filename.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

gitignore

In addition to the static cloud-config-aws.(ini|yml) files devs can create,
ansible-test may also create temporary credentials files with random strings
in the filename.
@tremble tremble added the gate label Nov 15, 2021
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 498b122 into ansible-collections:main Nov 15, 2021
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…boto3

Update the default module requirements from python 2.6/boto to python 3.6/boto3

SUMMARY
The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment.
Switch the defaults over to reduce the copy&paste and reflect that

boto v2 is deprecated
python 2.6 is no longer supported by the AWS collections

ISSUE TYPE

Docs Pull Request

COMPONENT NAME
lots of them
ADDITIONAL INFORMATION
Depends-On: ansible-collections#298

Reviewed-by: Jill R <None>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…boto3

Update the default module requirements from python 2.6/boto to python 3.6/boto3

SUMMARY
The vast bulk of modules are now boto3 based, but some even list python2.6/boto as their requirements because they've picked the default from the aws docs fragment.
Switch the defaults over to reduce the copy&paste and reflect that

boto v2 is deprecated
python 2.6 is no longer supported by the AWS collections

ISSUE TYPE

Docs Pull Request

COMPONENT NAME
lots of them
ADDITIONAL INFORMATION
Depends-On: ansible-collections#298

Reviewed-by: Jill R <None>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants