-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking Change] Remove support for old boto SDK (not boto3/botocore) #630
Merged
softwarefactory-project-zuul
merged 7 commits into
ansible-collections:main
from
tremble:boto/remove
Jan 28, 2022
Merged
[Breaking Change] Remove support for old boto SDK (not boto3/botocore) #630
softwarefactory-project-zuul
merged 7 commits into
ansible-collections:main
from
tremble:boto/remove
Jan 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
reviewed
Jan 21, 2022
This comment has been minimized.
This comment has been minimized.
CI failures aside the premise here lgtm. I'm excited to finally drop boto2! |
1 task
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tremble
changed the title
[DNM] Remove support for old boto SDK (not boto3/botocore)
[Breaking Change] Remove support for old boto SDK (not boto3/botocore)
Jan 25, 2022
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
has_issue
integration
tests/integration
module
module
module_utils
module_utils
plugins
plugin (any type)
tests
tests
labels
Jan 27, 2022
This comment has been minimized.
This comment has been minimized.
tremble
added
the
do_not_backport
This PR should not be backported to stable- branches unless absolutely necessary
label
Jan 28, 2022
…at we're in amazon.aws there isn't quite so much going on at the same time.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alinabuzachis
approved these changes
Jan 28, 2022
Build succeeded.
|
tremble
added
mergeit
Merge the PR (SoftwareFactory)
and removed
mergeit
Merge the PR (SoftwareFactory)
labels
Jan 28, 2022
Build succeeded (gate pipeline).
|
1 task
1 task
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Move changelog fragments to the right place SUMMARY Some changelog fragments landed in the wrong subfolder. Move them ISSUE TYPE Docs Pull Request COMPONENT NAME changelog ADDITIONAL INFORMATION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
do_not_backport
This PR should not be backported to stable- branches unless absolutely necessary
feature
This issue/PR relates to a feature request
has_issue
integration
tests/integration
mergeit
Merge the PR (SoftwareFactory)
module_utils
module_utils
module
module
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
It is time.
It's almost 3 years since the last code commit to the original boto library. We have deprecated and migrated. With 4.0.0 it is time for the last boto module and the relevant support code to be retired.
Depends-On: #632
Depends-On: #639
ISSUE TYPE
COMPONENT NAME
plugins/modules/ec2.py
plugins/module_utils/ec2.py
plugins/doc_fragments/aws.py
ADDITIONAL INFORMATION
IMO we should branch stable-3 sooner rather than later and start the cleanup work.
cc @jillr