Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Remove support for old boto SDK (not boto3/botocore) #630

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 21, 2022

SUMMARY

It is time.

It's almost 3 years since the last code commit to the original boto library. We have deprecated and migrated. With 4.0.0 it is time for the last boto module and the relevant support code to be retired.

Depends-On: #632
Depends-On: #639

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/ec2.py
plugins/module_utils/ec2.py
plugins/doc_fragments/aws.py

ADDITIONAL INFORMATION

IMO we should branch stable-3 sooner rather than later and start the cleanup work.

cc @jillr

@softwarefactory-project-zuul

This comment has been minimized.

@jillr
Copy link
Collaborator

jillr commented Jan 21, 2022

CI failures aside the premise here lgtm. I'm excited to finally drop boto2!

@softwarefactory-project-zuul

This comment has been minimized.

@softwarefactory-project-zuul

This comment has been minimized.

@softwarefactory-project-zuul

This comment has been minimized.

@softwarefactory-project-zuul

This comment has been minimized.

@tremble tremble changed the title [DNM] Remove support for old boto SDK (not boto3/botocore) [Breaking Change] Remove support for old boto SDK (not boto3/botocore) Jan 25, 2022
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request has_issue integration tests/integration module module module_utils module_utils plugins plugin (any type) tests tests labels Jan 27, 2022
@softwarefactory-project-zuul

This comment has been minimized.

@tremble tremble requested a review from jillr January 27, 2022 20:13
@jillr jillr mentioned this pull request Jan 27, 2022
1 task
@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label Jan 28, 2022
@softwarefactory-project-zuul

This comment has been minimized.

@tremble

This comment has been minimized.

tests/sanity/ignore-2.9.txt Show resolved Hide resolved
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 28, 2022
@tremble tremble added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels Jan 28, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 13f5963 into ansible-collections:main Jan 28, 2022
@tremble tremble deleted the boto/remove branch April 20, 2022 07:28
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Move changelog fragments to the right place

SUMMARY
Some changelog fragments landed in the wrong subfolder.  Move them
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
changelog
ADDITIONAL INFORMATION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request has_issue integration tests/integration mergeit Merge the PR (SoftwareFactory) module_utils module_utils module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants