-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagging - deprecate defaults of purge_tags=False #846
Merged
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:tagging/deprecate_purge/simple
May 31, 2022
Merged
Tagging - deprecate defaults of purge_tags=False #846
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:tagging/deprecate_purge/simple
May 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
module
module
needs_triage
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
labels
May 28, 2022
This comment was marked as resolved.
This comment was marked as resolved.
The simplest cases
tremble
force-pushed
the
tagging/deprecate_purge/simple
branch
from
May 28, 2022 15:05
2330d5d
to
5bf7d80
Compare
goneri
approved these changes
May 31, 2022
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #844
SUMMARY
The simple cases where we want to deprecate purge_tags=False
ISSUE TYPE
COMPONENT NAME
plugins/modules/ec2_ami.py
plugins/modules/ec2_key.py
plugins/modules/ec2_vol.py
plugins/modules/ec2_vpc_endpoint.py
plugins/modules/ec2_vpc_route_table.py
ADDITIONAL INFORMATION