Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ec2_group to ec2_security_group #897

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 24, 2022

SUMMARY

Rename ec2_group to ec2_security_group

There are multiple "groups" of resources in EC2 these days. Amazon documentation specifically refers to them as "security groups".

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_group
ec2_group_info
ec2_security_group
ec2_security_group_info

ADDITIONAL INFORMATION

This PR does not update integration tests with the renames to demonstrate that all of the aliasing pieces work.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Jun 24, 2022
@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul

This comment was marked as resolved.

tremble added 3 commits June 24, 2022 10:51
There are multiple "groups" of resources in EC2 these days.
@tremble tremble force-pushed the rename/ec2_security_group branch from 028a7cc to 5c86048 Compare June 24, 2022 08:51
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 25s
✔️ build-ansible-collection SUCCESS in 4m 44s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 45s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 44s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 00s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 57s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 28s
✔️ ansible-test-splitter SUCCESS in 2m 28s
✔️ integration-amazon.aws-1 SUCCESS in 12m 40s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble requested review from alinabuzachis and jillr June 24, 2022 09:19
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 12s
✔️ build-ansible-collection SUCCESS in 4m 55s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 05s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 44s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 14s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 29s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 19s
✔️ ansible-test-splitter SUCCESS in 2m 30s
✔️ integration-amazon.aws-1 SUCCESS in 14m 06s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 24, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 29s
✔️ build-ansible-collection SUCCESS in 5m 39s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 13s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 12s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 11m 10s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 27s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 03s
✔️ ansible-test-splitter SUCCESS in 2m 26s
✔️ integration-amazon.aws-1 SUCCESS in 12m 16s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ea405a5 into ansible-collections:main Jun 24, 2022
jatorcasso pushed a commit to jatorcasso/amazon.aws that referenced this pull request Jun 27, 2022
Rename ec2_group to ec2_security_group

SUMMARY
Rename ec2_group to ec2_security_group
There are multiple "groups" of resources in EC2 these days.  Amazon documentation specifically refers to them as "security groups".
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_group
ec2_group_info
ec2_security_group
ec2_security_group_info
ADDITIONAL INFORMATION
This PR does not update integration tests with the renames to demonstrate that all of the aliasing pieces work.

Reviewed-by: Alina Buzachis <None>
@tremble tremble deleted the rename/ec2_security_group branch September 9, 2022 08:51
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Bump release to 4.0.0-dev0

SUMMARY
See also: ansible-collections#639
Having released amazon.aws 3.0.0 and branched stable-3, bump the release to 4.0.0-dev0
The stable-3 branch now exists, as such we can start introducing the breaking changes slated for 4.0.0 rather than trying to push them in in the last few days before a release.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
galaxy.yml
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants