Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_ec2 doc guide #904

Merged
merged 11 commits into from
Aug 5, 2022
Merged

aws_ec2 doc guide #904

merged 11 commits into from
Aug 5, 2022

Conversation

alinabuzachis
Copy link
Collaborator

SUMMARY

aws_ec2 doc guide

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

aws_ec2

@github-actions
Copy link

github-actions bot commented Jun 27, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 47s
✔️ build-ansible-collection SUCCESS in 5m 03s
❌ ansible-test-sanity-aws-ansible-python38 FAILURE in 10m 13s
❌ ansible-test-sanity-aws-ansible-2.12-python38 FAILURE in 10m 32s
❌ ansible-test-sanity-aws-ansible-2.13-python38 FAILURE in 9m 05s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 43s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 41s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 51s
✔️ build-ansible-collection SUCCESS in 5m 16s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 35s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 30s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 42s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 11s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 59s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 53s
✔️ build-ansible-collection SUCCESS in 5m 25s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 58s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 36s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 56s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 44s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 17s

@alinabuzachis
Include aws_ec2_guide to toc
7fb0b26 
Signed-off-by: Alina Buzachis <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 5m 11s
✔️ build-ansible-collection SUCCESS in 5m 13s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 05s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 41s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 56s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 51s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 24s

tremble
tremble reviewed Jun 28, 2022
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm about half way through, but don't want to forget to submit these comments.

I really appreciate that you've written this, it took me a while to wrap my head around the inventory plugins and I've had to explain them to multiple colleagues.

docs/docsite/extra-docs.yml Outdated Show resolved Hide resolved
docs/docsite/rst/aws_ec2_guide.rst Outdated Show resolved Hide resolved
docs/docsite/rst/aws_ec2_guide.rst Outdated Show resolved Hide resolved
docs/docsite/rst/aws_ec2_guide.rst Outdated Show resolved Hide resolved
docs/docsite/rst/aws_ec2_guide.rst Outdated Show resolved Hide resolved
docs/docsite/rst/aws_ec2_guide.rst Outdated Show resolved Hide resolved
docs/docsite/rst/aws_ec2_guide.rst Outdated Show resolved Hide resolved
docs/docsite/rst/aws_ec2_guide.rst Show resolved Hide resolved
@alinabuzachis alinabuzachis force-pushed the aws_ec2_guide branch 3 times, most recently from 74f43da to 5b385da Compare July 8, 2022 14:49
@alinabuzachis
Update as per review
8f47556 
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis alinabuzachis requested a review from tremble July 8, 2022 15:04
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 09s
✔️ build-ansible-collection SUCCESS in 5m 20s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 07s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 05s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 09s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 50s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 15s

@alinabuzachis
Modify based on review
f92ecb8 
Signed-off-by: Alina Buzachis <[email protected]>
@alinabuzachis alinabuzachis requested a review from jillr July 15, 2022 11:41
tremble
tremble requested changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to submit the review. Looks really good

docs/docsite/rst/aws_ec2_guide.rst Outdated Show resolved Hide resolved
docs/docsite/rst/aws_ec2_guide.rst Outdated
Comment on lines 34 to 36
export AWS_SECRET_ACCESS_KEY='abc123'

The ``AWS_SECURITY_TOKEN`` environment variable can also be used, but is only supported for backward compatibility purposes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs a note about AWS_SESSION_TOKEN which is the replacement for AWS_SECURITY_TOKEN (generally used with temporary tokens)

docs/docsite/rst/aws_ec2_guide.rst Outdated Show resolved Hide resolved
docs/docsite/rst/aws_ec2_guide.rst Outdated Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 17s
✔️ build-ansible-collection SUCCESS in 5m 11s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 00s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 05s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 44s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 27s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 58s

@alinabuzachis
Apply suggestions
f5d360a 
Signed-off-by: Alina Buzachis <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 56s
✔️ build-ansible-collection SUCCESS in 4m 52s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 32s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 29s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 52s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 02s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 59s

@alinabuzachis
Apply missed suggestion
df93827 
Signed-off-by: Alina Buzachis <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 5m 10s
✔️ build-ansible-collection SUCCESS in 5m 27s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 52s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 41s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 23s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 56s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 12s

@alinabuzachis
Copy link
Collaborator Author

@ugwutotheeshoes Thank you for reviewing. Is there anything else I can improve on?

@ugwutotheeshoes
Copy link

@alinabuzachis No, you're good to go.

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Aug 5, 2022
@alinabuzachis
Copy link
Collaborator Author

@tremble don't we backport?

@tremble tremble added backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch labels Aug 5, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 10s
✔️ build-ansible-collection SUCCESS in 5m 13s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 13s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 55s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 32s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 39s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 17s

@softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@tremble tremble merged commit 4d195aa into ansible-collections:main Aug 5, 2022
@patchback
Copy link

patchback bot commented Aug 5, 2022 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/4d195aa2620a08ef14917712a1a909dffa053049/pr-904

Backported as #956

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 5, 2022
@alinabuzachis @patchback
aws_ec2 doc guide (#904)
cfb6161 
SUMMARY

aws_ec2 doc guide
ISSUE TYPE

    Docs Pull Request

COMPONENT NAME

aws_ec2

(cherry picked from commit 4d195aa)
@patchback patchback bot mentioned this pull request Aug 5, 2022
Merged
@patchback
Copy link

patchback bot commented Aug 5, 2022 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/4d195aa2620a08ef14917712a1a909dffa053049/pr-904

Backported as #957

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 5, 2022
@alinabuzachis @patchback
aws_ec2 doc guide (#904)
e8a8014 
SUMMARY

aws_ec2 doc guide
ISSUE TYPE

    Docs Pull Request

COMPONENT NAME

aws_ec2

(cherry picked from commit 4d195aa)
@patchback patchback bot mentioned this pull request Aug 5, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 5, 2022
@patchback
aws_ec2 doc guide (#904) (#957)
926662e 
[PR #904/4d195aa2 backport][stable-4] aws_ec2 doc guide

This is a backport of PR #904 as merged into main (4d195aa).
SUMMARY

aws_ec2 doc guide

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

aws_ec2

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Aug 5, 2022
@patchback
aws_ec2 doc guide (#904) (#956)
bb5f83e 
[PR #904/4d195aa2 backport][stable-3] aws_ec2 doc guide

This is a backport of PR #904 as merged into main (4d195aa).
SUMMARY

aws_ec2 doc guide

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

aws_ec2

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ugwutotheeshoes ugwutotheeshoes ugwutotheeshoes left review comments

@tremble tremble tremble approved these changes

@jillr jillr Awaiting requested review from jillr

Assignees
No one assigned
Labels
backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch community_review docs mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alinabuzachis @ugwutotheeshoes @tremble @jillr @ansibullbot