Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eks_nodegroup waiters #975

Conversation

tjarra
Copy link
Contributor

@tjarra tjarra commented Aug 24, 2022

SUMMARY

Add waiters for eks_nodegroup module to manage deleted and created states.

PR eks_nodegroup: ansible-collections/community.aws#1415

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

waiter.py

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module_utils module_utils needs_triage plugins plugin (any type) labels Aug 24, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 47s
✔️ build-ansible-collection SUCCESS in 5m 16s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 7m 52s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 02s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 18s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 57s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 11s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-amazon.aws-1 SUCCESS in 18m 53s
✔️ integration-amazon.aws-2 SUCCESS in 13m 48s
✔️ integration-amazon.aws-3 SUCCESS in 19m 42s
✔️ integration-amazon.aws-4 SUCCESS in 39m 49s
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 28m 22s
integration-community.aws-2 TIMED_OUT in 1h 00m 34s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
ansible-test-changelog FAILURE in 2m 14s

Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjarra Can you please add a changelog for this contributions? Thank you.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 12s
✔️ build-ansible-collection SUCCESS in 5m 09s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 16s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 31s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 30s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 30s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 48s
✔️ ansible-test-splitter SUCCESS in 2m 38s
✔️ integration-amazon.aws-1 SUCCESS in 18m 38s
✔️ integration-amazon.aws-2 SUCCESS in 12m 57s
✔️ integration-amazon.aws-3 SUCCESS in 20m 52s
integration-amazon.aws-4 FAILURE in 53m 11s
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
integration-community.aws-1 FAILURE in 32m 50s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 44s

@tjarra
Copy link
Contributor Author

tjarra commented Aug 29, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 10s
✔️ build-ansible-collection SUCCESS in 5m 11s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 29s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 13s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 27s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 10s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 53s
✔️ ansible-test-splitter SUCCESS in 3m 30s
✔️ integration-amazon.aws-1 SUCCESS in 19m 03s
✔️ integration-amazon.aws-2 SUCCESS in 11m 44s
✔️ integration-amazon.aws-3 SUCCESS in 21m 44s
✔️ integration-amazon.aws-4 SUCCESS in 40m 44s
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
integration-community.aws-1 FAILURE in 8m 07s
✔️ integration-community.aws-2 SUCCESS in 9m 27s
✔️ integration-community.aws-3 SUCCESS in 24m 12s
✔️ integration-community.aws-4 SUCCESS in 50m 49s
✔️ integration-community.aws-5 SUCCESS in 24m 28s
✔️ integration-community.aws-6 SUCCESS in 52m 20s
✔️ integration-community.aws-7 SUCCESS in 46m 47s
✔️ integration-community.aws-8 SUCCESS in 7m 54s
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 36s

@goneri
Copy link
Member

goneri commented Aug 30, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 18s
✔️ build-ansible-collection SUCCESS in 4m 55s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 45s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 13s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 38s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 55s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 00s
✔️ ansible-test-splitter SUCCESS in 2m 33s
✔️ integration-amazon.aws-1 SUCCESS in 17m 30s
✔️ integration-amazon.aws-2 SUCCESS in 11m 35s
✔️ integration-amazon.aws-3 SUCCESS in 20m 20s
✔️ integration-amazon.aws-4 SUCCESS in 42m 03s
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 34m 19s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 17s

@gravesm gravesm added mergeit Merge the PR (SoftwareFactory) and removed needs_triage labels Sep 6, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 5m 20s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 41s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 12s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 22s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 44s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 18s
✔️ ansible-test-splitter SUCCESS in 2m 36s
✔️ integration-amazon.aws-1 SUCCESS in 18m 07s
✔️ integration-amazon.aws-2 SUCCESS in 15m 07s
✔️ integration-amazon.aws-3 SUCCESS in 22m 18s
✔️ integration-amazon.aws-4 SUCCESS in 48m 05s
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 27m 25s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 15s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 93f8ce1 into ansible-collections:main Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul bot pushed a commit to ansible-collections/community.aws that referenced this pull request Feb 3, 2023
[PR #1415/3f37c975 backport][stable-5] New Module - eks_nodegroup

This is a backport of PR #1415 as merged into main (3f37c97).
SUMMARY
Add a new module to manage nodegroups in EKS clusters.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
eks_nodegroup
ADDITIONAL INFORMATION
TODO:

 PR ansible-collections/amazon.aws/pull/975 to add waiters for EKS nodegroup.
 PR aws-terminator/pull/223 to add permissions to execute integration tests.

- name: create nodegroup
  community.aws.eks_nodegroup:
    name: test_nodegroup
    state: present
    cluster_name: test_cluster
    node_role: arn:aws:eks:us-east-1:1231231123:role/asdf
    subnets:
      - subnet-qwerty123
      - subnet-asdfg456
    scaling_config:
      - min_size: 1
      - max_size: 2
      - desired_size: 1
    disk_size: 20
    instance_types: 't3.micro'
    ami_type: 'AL2_x86_64'
    labels:
      - 'teste': 'test'
    taints:
      - key: 'test'
        value: 'test'
        effect: 'NO_SCHEDULE'
    capacity_type: 'on_demand'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module_utils module_utils plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants