Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Module - eks_nodegroup #1415

Merged
merged 10 commits into from
Feb 3, 2023
Merged

Conversation

tjarra
Copy link
Contributor

@tjarra tjarra commented Aug 18, 2022

SUMMARY

Add a new module to manage nodegroups in EKS clusters.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

eks_nodegroup

ADDITIONAL INFORMATION

TODO:

- name: create nodegroup
  community.aws.eks_nodegroup:
    name: test_nodegroup
    state: present
    cluster_name: test_cluster
    node_role: arn:aws:eks:us-east-1:1231231123:role/asdf
    subnets:
      - subnet-qwerty123
      - subnet-asdfg456
    scaling_config:
      - min_size: 1
      - max_size: 2
      - desired_size: 1
    disk_size: 20
    instance_types: 't3.micro'
    ami_type: 'AL2_x86_64'
    labels:
      - 'teste': 'test'
    taints:
      - key: 'test'
        value: 'test'
        effect: 'NO_SCHEDULE'
    capacity_type: 'on_demand'

@tjarra tjarra changed the title Eks nodegroup New Module - eks_nodegroup Aug 18, 2022
@github-actions
Copy link

github-actions bot commented Aug 18, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 5m 00s
ansible-test-sanity-docker-devel FAILURE in 10m 41s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 32s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 31s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 49s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 00s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 53s
✔️ ansible-test-splitter SUCCESS in 2m 29s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Sep 6, 2022
Add eks_nodegroup waiters

SUMMARY
Add waiters for eks_nodegroup module to manage deleted and created states.
PR eks_nodegroup: ansible-collections/community.aws#1415
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
waiter.py

Reviewed-by: Alina Buzachis <None>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 10s
✔️ build-ansible-collection SUCCESS in 5m 49s
ansible-test-sanity-docker-devel FAILURE in 9m 26s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 33s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 28s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 13m 11s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 45s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 47s
✔️ ansible-test-splitter SUCCESS in 2m 40s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@gravesm
Copy link
Member

gravesm commented Oct 3, 2022

The permissions for CI should now be set, but I had a difficult time getting this test suite to pass. It just takes too long. My suggestion would be to try being more economical in what is being tested if possible, and only use wait: True in cases where it is absolutely necessary. Also, this PR will need an alias file for the test target in order for the tests to run.

@tjarra
Copy link
Contributor Author

tjarra commented Oct 10, 2022

Thanks for the feedback @gravesm
Yeah, i also think it's taking too long to run, i will review the tests to reduce the time and add the alias.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 41s
✔️ build-ansible-collection SUCCESS in 5m 31s
ansible-test-sanity-docker-devel FAILURE in 9m 37s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 10m 13s
ansible-test-sanity-docker-stable-2.12 FAILURE in 10m 41s
ansible-test-sanity-docker-stable-2.13 FAILURE in 10m 08s
ansible-test-sanity-docker-stable-2.14 FAILURE in 8m 55s (non-voting)
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 33s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 38s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 22s
✔️ ansible-test-splitter SUCCESS in 2m 38s
integration-community.aws-1 TIMED_OUT in 1h 00m 43s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 32s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 31s
✔️ build-ansible-collection SUCCESS in 5m 04s
ansible-test-sanity-docker-devel FAILURE in 10m 29s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 49s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 14s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 39s
ansible-test-sanity-docker-stable-2.14 FAILURE in 9m 15s (non-voting)
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 01s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 08s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 43s
✔️ ansible-test-splitter SUCCESS in 2m 48s
✔️ integration-community.aws-1 SUCCESS in 25m 42s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 20s

plugins/modules/eks_nodegroup.py Outdated Show resolved Hide resolved
plugins/modules/eks_nodegroup.py Outdated Show resolved Hide resolved
plugins/modules/eks_nodegroup.py Outdated Show resolved Hide resolved
plugins/modules/eks_nodegroup.py Outdated Show resolved Hide resolved
plugins/modules/eks_nodegroup.py Outdated Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 5m 05s
ansible-test-sanity-docker-devel FAILURE in 11m 37s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 9m 49s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 54s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 26s
ansible-test-sanity-docker-stable-2.14 FAILURE in 10m 04s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 58s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 05s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 48s
✔️ ansible-test-changelog SUCCESS in 2m 12s
✔️ ansible-test-splitter SUCCESS in 2m 23s
✔️ integration-community.aws-1 SUCCESS in 27m 33s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 6m 43s
ansible-test-sanity-docker-devel FAILURE in 12m 28s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 9m 14s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 52s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 59s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 14s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 11s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 55s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 41s
✔️ ansible-test-changelog SUCCESS in 2m 26s
✔️ ansible-test-splitter SUCCESS in 4m 11s
✔️ integration-community.aws-1 SUCCESS in 25m 32s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@filipecifali
Copy link

filipecifali commented Jan 24, 2023

This is super useful! Brilliant work! Is there anything we can do to help get this merged / released?

plugins/modules/eks_nodegroup.py Show resolved Hide resolved
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Feb 3, 2023
@tremble tremble added the backport-5 PR should be backported to the stable-5 branch label Feb 3, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 32s
✔️ build-ansible-collection SUCCESS in 5m 49s
ansible-test-sanity-docker-devel FAILURE in 10m 18s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 8m 49s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 05s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 34s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 48s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 56s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 29s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 33s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 21s
✔️ ansible-test-changelog SUCCESS in 2m 08s
✔️ ansible-test-splitter SUCCESS in 2m 25s
✔️ integration-community.aws-1 SUCCESS in 24m 41s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@tremble tremble merged commit 3f37c97 into ansible-collections:main Feb 3, 2023
@patchback
Copy link

patchback bot commented Feb 3, 2023

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/3f37c9758777b76afa8ba50fc9dfd64dc31fcff7/pr-1415

Backported as #1702

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 3, 2023
SUMMARY

Add a new module to manage nodegroups in EKS clusters.

ISSUE TYPE

    New Module Pull Request

COMPONENT NAME

eks_nodegroup

ADDITIONAL INFORMATION

(cherry picked from commit 3f37c97)
@tremble
Copy link
Contributor

tremble commented Feb 3, 2023

Hi all,

Sorry this has taken so long to get merged. This should be available once we release 5.3.0

@tjarra Many thanks for your work here.

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 3, 2023
Bump release_version for eks_nodegroup

SUMMARY
Couldn't bump the version in #1415 - bumping it here
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
eks_nodegroup
ADDITIONAL INFORMATION
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 3, 2023
[PR #1415/3f37c975 backport][stable-5] New Module - eks_nodegroup

This is a backport of PR #1415 as merged into main (3f37c97).
SUMMARY
Add a new module to manage nodegroups in EKS clusters.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
eks_nodegroup
ADDITIONAL INFORMATION
TODO:

 PR ansible-collections/amazon.aws/pull/975 to add waiters for EKS nodegroup.
 PR aws-terminator/pull/223 to add permissions to execute integration tests.

- name: create nodegroup
  community.aws.eks_nodegroup:
    name: test_nodegroup
    state: present
    cluster_name: test_cluster
    node_role: arn:aws:eks:us-east-1:1231231123:role/asdf
    subnets:
      - subnet-qwerty123
      - subnet-asdfg456
    scaling_config:
      - min_size: 1
      - max_size: 2
      - desired_size: 1
    disk_size: 20
    instance_types: 't3.micro'
    ami_type: 'AL2_x86_64'
    labels:
      - 'teste': 'test'
    taints:
      - key: 'test'
        value: 'test'
        effect: 'NO_SCHEDULE'
    capacity_type: 'on_demand'
patchback bot pushed a commit that referenced this pull request Feb 3, 2023
Bump release_version for eks_nodegroup

SUMMARY
Couldn't bump the version in #1415 - bumping it here
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
eks_nodegroup
ADDITIONAL INFORMATION

(cherry picked from commit 80ca4fe)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 3, 2023
[PR #1703/80ca4fe4 backport][stable-5] Bump release_version for eks_nodegroup

This is a backport of PR #1703 as merged into main (80ca4fe).
SUMMARY
Couldn't bump the version in #1415 - bumping it here
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
eks_nodegroup
ADDITIONAL INFORMATION
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-5 PR should be backported to the stable-5 branch community_review has_issue integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants