Add abort multipart upload and expire obj del markers to s3 lifecycle #794

mdavis-xyz · 2021-11-08T00:42:08Z

Depends-On: ansible/ansible-zuul-jobs#1247

SUMMARY

Fixes ~~#365~~ #796

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

s3_lifecycle

ADDITIONAL INFORMATION

I have not run integration tests yet because of ansible-collections/amazon.aws#924.

I'm unsure about how to name and structure the new arguments.
Do I nest them to match the API, or flatten them to match existing arguments?

mdavis-xyz · 2021-11-10T23:00:38Z

Why does the CICD say

ansible/gate Expected — Waiting for status to be reported

What does that mean?

markuman · 2021-11-11T06:46:55Z

Why does the CICD say

ansible/gate Expected — Waiting for status to be reported

What does that mean?

It's just waiting for at least two reviewers/approvals.

tremble · 2021-11-11T08:20:36Z

What does that mean?

It means that the conditions for the "gate" job hasn't been met, so the job hasn't been allowed to run. It's based on the work that the OpenStack folks have done https://dague.net/2013/02/21/the-openstack-gate/

Once triggered (and successful) Zuul will automatically merge the change. Nominally it's a subset of the 'ansible/check' tests and it's used to ensure that between ansible/check having been run and the change being approved another change hasn't been introduced that clashes with this one (for example a function the change depended on being modified in an incompatible manner)

alinabuzachis

@mdavis-xyz Thank you for working on this. Generally this LGTM! Could you also please add a changelog fragment?

plugins/modules/s3_lifecycle.py

goneri · 2021-11-30T19:30:28Z

check ondemand

goneri · 2021-11-30T19:45:04Z

check ondemand

Co-authored-by: Alina Buzachis <[email protected]>

mdavis-xyz · 2021-11-30T22:33:48Z

I've added the changelog, and changed C() to I(). (Although I don't know what the difference between C and I is)

tremble · 2021-12-01T09:04:01Z

https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#linking-and-other-format-macros-within-module-documentation

There are also some macros which do not create links but we use them to display certain types of content in a uniform way:

    I() for option names. For example: Required if I(state=present). This is italicized in the documentation.

    C() for files, option values, and inline code. For example: If not set the environment variable C(ACME_PASSWORD) will be used. or Use C(var | foo.bar.my_filter) to transform C(var) into the required format. This displays with a mono-space font in the documentation.

ansible-zuul

LGTM!

plugins/modules/s3_lifecycle.py

issues addressed

tremble · 2021-12-02T09:58:25Z

recheck

changelogs/fragments/794-s3_lifecycle_abort_expire.yml

Co-authored-by: Alina Buzachis <[email protected]>

mdavis-xyz · 2021-12-22T23:50:12Z

Can someone please open the gate for me?

patchback · 2022-01-14T12:06:50Z

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/ed3a7a0b0ae86cbcaed733ada1f88a27917e1a09/pr-794

Backported as #864

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

…#794) Add abort multipart upload and expire obj del markers to s3 lifecycle Depends-On: ansible/ansible-zuul-jobs#1247 SUMMARY Fixes #365 #796 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION I have not run integration tests yet because of #793. I'm unsure about how to name and structure the new arguments. Do I nest them to match the API, or flatten them to match existing arguments? Reviewed-by: Alina Buzachis <None> Reviewed-by: Matthew Davis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit ed3a7a0)

…#794) (#864) [PR #794/ed3a7a0b backport][stable-2] Add abort multipart upload and expire obj del markers to s3 lifecycle This is a backport of PR #794 as merged into main (ed3a7a0). Depends-On: ansible/ansible-zuul-jobs#1247 SUMMARY Fixes #365 #796 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_lifecycle ADDITIONAL INFORMATION I have not run integration tests yet because of #793. I'm unsure about how to name and structure the new arguments. Do I nest them to match the API, or flatten them to match existing arguments?

Updates to the Developer Guidelines SUMMARY Updates for the Developer Guidelines (originally started as ansible/ansible#77598) ISSUE TYPE Docs Pull Request COMPONENT NAME docs/docsite/rst/dev_guidelines.rst ADDITIONAL INFORMATION Validation run can be found at: https://github.com/tremble/amazon.aws/runs/6192239999?check_suite_focus=true Reviewed-by: Felix Fontein <[email protected]> Reviewed-by: Alina Buzachis <None>

mdavis-xyz and others added 2 commits November 7, 2021 22:55

Add abort multipart upload and expire obj del markers to s3 lifecycle

ba42fac

fix missing new abort/expire args in s3_lifecycle spec

5fe4863

mdavis-xyz force-pushed the s3_lifecycle_abort_expire branch from eee8b44 to 5fe4863 Compare November 9, 2021 23:11

alinabuzachis previously requested changes Nov 30, 2021

View reviewed changes

mdavis-xyz and others added 5 commits December 1, 2021 09:01

Add C() to docs for s3_lifecycle

64e09f3

Co-authored-by: Alina Buzachis <[email protected]>

add changelog for new abort and expire fields in s3_lifecycle

71ae5ee

Change C() to I() in s3_lifecycle docs

1f74b8f

Co-authored-by: Alina Buzachis <[email protected]>

Change C() to I() in s3_lifecycle docs

81c6c39

Co-authored-by: Alina Buzachis <[email protected]>

Change C() to I() in s3_lifecycle docs

7b2b8a0

Co-authored-by: Alina Buzachis <[email protected]>

tremble approved these changes Dec 1, 2021

View reviewed changes

tremble added backport-2 PR should be backported to the stable-2 branch gate labels Dec 1, 2021

ansible-zuul bot approved these changes Dec 1, 2021

View reviewed changes

tremble requested a review from alinabuzachis December 1, 2021 12:33

markuman reviewed Dec 1, 2021

View reviewed changes

plugins/modules/s3_lifecycle.py Show resolved Hide resolved

update version_added

55918ec

markuman reviewed Dec 1, 2021

View reviewed changes

plugins/modules/s3_lifecycle.py Show resolved Hide resolved

ansible-zuul bot removed the gate label Dec 1, 2021

update version_added

da0ede3

markuman reviewed Dec 1, 2021

View reviewed changes

plugins/modules/s3_lifecycle.py Outdated Show resolved Hide resolved

revert version_added

ea1af26

markuman reviewed Dec 1, 2021

View reviewed changes

plugins/modules/s3_lifecycle.py Outdated Show resolved Hide resolved

revert version_added

759e949

markuman added the gate label Dec 1, 2021

tremble removed the gate label Dec 2, 2021

alinabuzachis reviewed Dec 2, 2021

View reviewed changes

changelogs/fragments/794-s3_lifecycle_abort_expire.yml Outdated Show resolved Hide resolved

Update changelogs for s3_lifecycle_abort_expire

9fe5d8a

Co-authored-by: Alina Buzachis <[email protected]>

markuman added the gate label Jan 14, 2022

ansible-zuul bot merged commit ed3a7a0 into ansible-collections:main Jan 14, 2022

patchback bot mentioned this pull request Jan 14, 2022

[PR #794/ed3a7a0b backport][stable-2] Add abort multipart upload and expire obj del markers to s3 lifecycle #864

Merged

markuman mentioned this pull request Jan 17, 2022

s3_lifecycle: incr version_added #873

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add abort multipart upload and expire obj del markers to s3 lifecycle #794

Add abort multipart upload and expire obj del markers to s3 lifecycle #794

mdavis-xyz commented Nov 8, 2021 •

edited by goneri

Loading

mdavis-xyz commented Nov 10, 2021

markuman commented Nov 11, 2021

tremble commented Nov 11, 2021

alinabuzachis left a comment

goneri commented Nov 30, 2021

goneri commented Nov 30, 2021

mdavis-xyz commented Nov 30, 2021

tremble commented Dec 1, 2021

ansible-zuul bot left a comment

tremble commented Dec 2, 2021

mdavis-xyz commented Dec 22, 2021 •

edited

Loading

patchback bot commented Jan 14, 2022 •

edited

Loading

Add abort multipart upload and expire obj del markers to s3 lifecycle #794

Add abort multipart upload and expire obj del markers to s3 lifecycle #794

Conversation

mdavis-xyz commented Nov 8, 2021 • edited by goneri Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

mdavis-xyz commented Nov 10, 2021

markuman commented Nov 11, 2021

tremble commented Nov 11, 2021

alinabuzachis left a comment

Choose a reason for hiding this comment

goneri commented Nov 30, 2021

goneri commented Nov 30, 2021

mdavis-xyz commented Nov 30, 2021

tremble commented Dec 1, 2021

ansible-zuul bot left a comment

Choose a reason for hiding this comment

tremble commented Dec 2, 2021

mdavis-xyz commented Dec 22, 2021 • edited Loading

patchback bot commented Jan 14, 2022 • edited Loading

Backport to stable-2: 💚 backport PR created

mdavis-xyz commented Nov 8, 2021 •

edited by goneri

Loading

mdavis-xyz commented Dec 22, 2021 •

edited

Loading

patchback bot commented Jan 14, 2022 •

edited

Loading