Multiple ansible community repos contain .swp files

[nkadel]

Multiple ansible community repos, assembled by this tool, contain extraneous ".swp" files. these are always erroneously commited vim temporary files, and should be excluded. The list is:

• ansible-5.0.0/ansible_collections/infinidat/infinibox/.Makefile.swp
• ansible-5.0.0/ansible_collections/infinidat/infinibox/.README.md.swp
• ansible-5.0.0/ansible_collections/infinidat/infinibox/.galaxy.yml.swp
• ansible-5.0.0/ansible_collections/infinidat/infinibox/docs/.DEV_README.md.swp
• ansible-5.0.0/ansible_collections/infinidat/infinibox/plugins/modules/.infini_map.py.swp
• ansible-5.0.0/ansible_collections/vyos/vyos/tests/unit/modules/network/vyos/.test_vyos_firewall_rules.py.swp

[felixfontein]

Please create issues in the corresponding repositories and ask their maintainers to remove these files from the next release.

For Ansible 6 we can try to automatically remove them from the built dist, but we cannot remove anything from the source dist.

[nkadel]

They could be excluded from the tar command. But yeah, I'll pursue that with the repo owners.

This sort of inappropriate artifact is going to keep happening with so many distinct third-party maintained repos.

[gundalow]

@nkadel Thank you for taking the time to report this.

I think a general tidy up is needed across all collections included in the ansible package.

1. Ensure they have the latest version of https://github.com/ansible-collections/collection_template/blob/main/.gitignore
2. Script (or maybe one exists) to warn if any files in the repo match gitignore, then delete them

[nkadel]

A glance at the .gitignore files might be in order as well. '*.swp' for vim fans, for example, is useful.

[nkadel]

I'd not recommend trying to outsmart a developer who has chosen to deliberately override .gitignore. I know I've done so on occasion, with cause, and would have broken my software to have someone apply .gitignore exclusions after the fact.