Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to remove specific collection changelog entries from Ansible changelog #639

Merged
merged 3 commits into from
Nov 3, 2024

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Oct 19, 2024

@felixfontein
Copy link
Collaborator Author

(This uses ansible-community/antsibull-changelog#181, which I just merged before re-triggering the failing tests...)

@felixfontein felixfontein force-pushed the changelog-cleanup branch 2 times, most recently from ddbad92 to 2be55ab Compare October 19, 2024 19:25
@felixfontein felixfontein changed the title [WIP] Allow to remove specific collection changelog entries from Ansible changelog Allow to remove specific collection changelog entries from Ansible changelog Oct 27, 2024
@felixfontein felixfontein marked this pull request as ready for review October 27, 2024 07:15
Copy link

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand all of your code, but the result in ansible-community/ansible-build-data#487 LGTM!

src/antsibull_build/changelog.py Outdated Show resolved Hide resolved
src/antsibull_build/changelog.py Outdated Show resolved Hide resolved
felixfontein and others added 2 commits November 3, 2024 10:54
Co-authored-by: Maxwell G <[email protected]>
@felixfontein
Copy link
Collaborator Author

(CI fails for Ansible 8 since the latest version of cyberark.conjur uses Python features not available with the Python version for the bytecompile test. I'm going to ignore this for now, and add a constraint into ansible-build-data for Ansible 8.)

@felixfontein
Copy link
Collaborator Author

@felixfontein felixfontein merged commit 4ac4979 into ansible-community:main Nov 3, 2024
9 checks passed
@felixfontein felixfontein deleted the changelog-cleanup branch November 3, 2024 10:23
@felixfontein
Copy link
Collaborator Author

@mariolenz @gotmax23 thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants