Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two runtime warnings #1102

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Fix two runtime warnings #1102

merged 2 commits into from
Jul 20, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jul 15, 2022

  • Replace deprecated pipes.quote with shlex.quote
  • Fix file handle not being closed

Both were observed as affecting ansible-navigator testing, which is configured to run with warnings as errors. Ideally we should be able to do the here with runner at some point.

Fixes #1101

@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Jul 15, 2022
@ssbarnea ssbarnea marked this pull request as ready for review July 15, 2022 11:10
@ssbarnea ssbarnea requested a review from a team as a code owner July 15, 2022 11:10
@ssbarnea ssbarnea changed the title Replace deprecated pipes.quote with shlex.quote Fix two runtime warnings Jul 15, 2022
@Akasurde Akasurde merged commit 3461a40 into ansible:devel Jul 20, 2022
@ssbarnea ssbarnea deleted the fix/py311 branch July 20, 2022 09:20
@sivel sivel removed the needs_triage New item that needs to be triaged label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipes is deprecated in python 3.13
6 participants