Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_package support for non-default installation parameters #50778

Closed
avishefi opened this issue Jan 10, 2019 · 8 comments
Closed

win_package support for non-default installation parameters #50778

avishefi opened this issue Jan 10, 2019 · 8 comments
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. P3 Priority 3 - Approved, No Time Limitation support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community

Comments

@avishefi
Copy link
Contributor

SUMMARY

win_package to support non-default installation parameters

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

win_package

ADDITIONAL INFORMATION

Currently win_package forces a default set of installation parameters:
https://github.com/ansible/ansible/blob/v2.7.5/lib/ansible/modules/windows/win_package.ps1#L340
This prevents the use of alternative flags, such as administrative installation (/a) different logging levels, etc.

It would be great to support overriding these command-line arguments.

@avishefi avishefi changed the title win_package non-default install parameters win_package support for non-default install parameters Jan 10, 2019
@avishefi avishefi changed the title win_package support for non-default install parameters win_package support for non-default installation parameters Jan 10, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 10, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 10, 2019

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Jan 10, 2019
@bcoca bcoca added P3 Priority 3 - Approved, No Time Limitation and removed needs_triage Needs a first human triage before being processed. labels Jan 15, 2019
@agowa
Copy link
Contributor

agowa commented Jan 21, 2019

How should /a be usefull for this module? Can you explain what you want to archive?
Normally /a is used if one wants to create a installation package, but not within a production environment.
And why do you need additional logging levels? This module should install or uninstall a program.

@ansibot
Copy link
Contributor

ansibot commented Feb 22, 2019

cc @if-meaton
click here for bot help

@avishefi
Copy link
Contributor Author

avishefi commented Apr 7, 2019

I agree, the module should install or uninstall a program. Other use cases should be handled by invoking msiexec directly using a shell command. We can close this issue as it is irrelevant.

@ansibot
Copy link
Contributor

ansibot commented Apr 15, 2019

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jun 2, 2019

@jborean93
Copy link
Contributor

This is not a feature we want ot implement on win_package. That module is designed to be a fairly install and uninstall of various package types and we don't want to overload it with package specific options. The best bet is to just use win_command with args: creates as an idempotent way to run the command you desire.

@ansible ansible locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. P3 Priority 3 - Approved, No Time Limitation support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Development

No branches or pull requests

5 participants