Skip to content

Commit

Permalink
🎨🧪 Include linters into the main CI workflow
Browse files Browse the repository at this point in the history
This approach allows depending on linting outcome in the branch
protection. It also lets us keep the workflow bits modular.
  • Loading branch information
webknjaz committed May 10, 2023
1 parent dcc1415 commit ac21066
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 15 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/build-test-n-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ env:
jobs:
lint:
uses: ./.github/workflows/reusable-linters.yml

pre-setup:
name: ⚙️ Pre-set global build settings
runs-on: ubuntu-latest
Expand Down Expand Up @@ -2104,6 +2107,7 @@ jobs:
needs:
- build-rpms
- dist-meta
- lint
- test-linux
- test-macos

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,7 @@
name: 🚨

on: # yamllint disable-line rule:truthy
push:
branches-ignore:
# NOTE: bot-managed branches don't need to be linted on
# NOTE: push: they always have PR builds
- dependabot/**
pull_request:
schedule:
- cron: 1 0 * * * # Run daily at 0:01 UTC
# Run every Friday at 18:02 UTC
# https://crontab.guru/#2_18_*_*_5
# - cron: 2 18 * * 5
workflow_call:

jobs:
linters:
Expand Down
4 changes: 0 additions & 4 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@
:alt: GitHub Workflow Status (🏗 📦 & test & publish/devel)
:target: https://github.com/ansible/pylibssh/actions?query=workflow%3A%22%F0%9F%8F%97+%F0%9F%93%A6+%26+test+%26+publish%22+branch%3Adevel

.. image:: https://img.shields.io/github/workflow/status/ansible/pylibssh/%F0%9F%9A%A8/devel?label=GitHub%20Actions%20%5Bquality%5D&logo=github
:target: https://github.com/ansible/pylibssh/actions?query=workflow%3A%F0%9F%9A%A8+branch%3Adevel
:alt: GitHub Workflow Status (🚨/devel)

.. image:: https://img.shields.io/codecov/c/gh/ansible/pylibssh/devel?logo=codecov&logoColor=white
:target: https://codecov.io/gh/ansible/pylibssh
:alt: devel branch coverage via Codecov
Expand Down

0 comments on commit ac21066

Please sign in to comment.