Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for replacing the mesh #548

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

greschd
Copy link
Member

@greschd greschd commented Jul 9, 2024

No description provided.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/adaptive_mesh_workflow@7949116). Learn more about missing BASE report.

Files Patch % Lines
src/ansys/acp/core/_tree_objects/model.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##             feat/adaptive_mesh_workflow     #548   +/-   ##
==============================================================
  Coverage                               ?   91.98%           
==============================================================
  Files                                  ?       82           
  Lines                                  ?     4291           
  Branches                               ?        0           
==============================================================
  Hits                                   ?     3947           
  Misses                                 ?      344           
  Partials                               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

unit_system: UnitSystemType = UnitSystemType.UNDEFINED,
) -> None:
"""
Replace the mesh of the model.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we should document that it can also be used to reload a mesh.

@greschd greschd enabled auto-merge (squash) July 9, 2024 11:12
@greschd greschd merged commit f1b727a into feat/adaptive_mesh_workflow Jul 9, 2024
28 checks passed
@greschd greschd deleted the feat/replace_mesh branch July 9, 2024 11:33
greschd added a commit that referenced this pull request Oct 21, 2024
Add a method `replace_mesh` to the `Model`, to replace the
mesh with a new one stored in a file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants