-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR: Loading dotnet runtime #5555
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Hi @AlfVII @clguenthe I'm pinging you because, following a previous issue, I had the feeling that you might still be using PyAEDT with dotnet. If that's the case, could you give a try at this PR to check that it suits you well ? If something is wrong, please let me know ! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5555 +/- ##
==========================================
+ Coverage 84.85% 84.90% +0.05%
==========================================
Files 144 144
Lines 60630 60675 +45
==========================================
+ Hits 51445 51519 +74
+ Misses 9185 9156 -29 |
Description
To improve compatibility with system libraries in Linux, the Python package
dotnetcore2
should be removed from PyAEDT's dotnet installation target. Indeed, the embedded version of.NET
associated todotnetcore2
is old and has incompatibilities with recent versions ofopenssl
such as the one installed by default in Ubuntu 22.04.This PR propose to add this modification to the breaking changes of release v1.0 and, in the mean time, to allow users to:
dotnetcore2
dotnetcore2
approach if no .NET runtime is detected / provided through environment variable (DOTNET_ROOT).Issue linked
See #5554
Note
Tests implementation differs from pyedb since pyaedt has a
filterwarnings
option for pytest.Warning
DO NOT MERGE until feedback is provided