Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Loading dotnet runtime #5555

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Dec 10, 2024

Description

To improve compatibility with system libraries in Linux, the Python package dotnetcore2 should be removed from PyAEDT's dotnet installation target. Indeed, the embedded version of .NET associated to dotnetcore2 is old and has incompatibilities with recent versions of openssl such as the one installed by default in Ubuntu 22.04.

This PR propose to add this modification to the breaking changes of release v1.0 and, in the mean time, to allow users to:

  • use a .NET runtime that they have installed instead of the one embedded in dotnetcore2
  • fallback to the dotnetcore2 approach if no .NET runtime is detected / provided through environment variable (DOTNET_ROOT).

Issue linked

See #5554


Note

Tests implementation differs from pyedb since pyaedt has a filterwarnings option for pytest.


Warning

DO NOT MERGE until feedback is provided

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@SMoraisAnsys SMoraisAnsys self-assigned this Dec 10, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 10, 2024
@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Dec 10, 2024

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities
Data Finding Sensitive Data 1 Info
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
Total 1 Info

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@SMoraisAnsys
Copy link
Collaborator Author

Hi @AlfVII @clguenthe I'm pinging you because, following a previous issue, I had the feeling that you might still be using PyAEDT with dotnet. If that's the case, could you give a try at this PR to check that it suits you well ? If something is wrong, please let me know !

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 93.87755% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.90%. Comparing base (9713da3) to head (a81ca96).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5555      +/-   ##
==========================================
+ Coverage   84.85%   84.90%   +0.05%     
==========================================
  Files         144      144              
  Lines       60630    60675      +45     
==========================================
+ Hits        51445    51519      +74     
+ Misses       9185     9156      -29     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant