Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulate the dimensions functionality in a class/module #312

Open
hpohekar opened this issue Nov 6, 2024 · 0 comments
Open

Encapsulate the dimensions functionality in a class/module #312

hpohekar opened this issue Nov 6, 2024 · 0 comments
Assignees
@hpohekar

Comments

@hpohekar
Copy link
Collaborator

hpohekar commented Nov 6, 2024

a hard-coded check for angles (no longer configurable). The original point was about encapsulation. We need to encapsulate the dimensions functionality in a class/module that's concerned with dimensions, not spread the functionality all around.
@hpohekar hpohekar self-assigned this Nov 6, 2024
@hpohekar hpohekar mentioned this issue Nov 6, 2024
Merged
@hpohekar hpohekar linked a pull request Nov 6, 2024 that will close this issue
feat: Configure angle as dimension #309
Merged
@hpohekar hpohekar removed a link to a pull request Nov 6, 2024
feat: Configure angle as dimension #309
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hpohekar hpohekar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hpohekar