Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate surprises from ansys.fluent.core.services.field_data.FieldData #932

Closed
seanpearsonuk opened this issue Sep 26, 2022 · 0 comments · Fixed by #948
Closed

Eliminate surprises from ansys.fluent.core.services.field_data.FieldData #932

seanpearsonuk opened this issue Sep 26, 2022 · 0 comments · Fixed by #948
Assignees

Comments

@seanpearsonuk
Copy link
Collaborator

seanpearsonuk commented Sep 26, 2022

Problem is that get_fields etc is in the same interface as all this query builder stuff. This doesn't sit together properly and is baffling on first view. Queries could be separate objects returned by FieldData. The programmer would build the query and use it directly via its own interface only.

  • rm get_fields etc from FieldData
  • rm add_get_etc methods from FieldData
  • create new query class
  • make query objects createable via FieldData public interface
  • add interface to query objects so that query can be built and executed
  • add simple "single shot" interface to FieldData
@prmukherj prmukherj moved this from Backlog to Prioritised in PyFluent Public Roadmap Sep 29, 2022
@prmukherj prmukherj linked a pull request Sep 29, 2022 that will close this issue
@prmukherj prmukherj moved this from Prioritised to Selected in PyFluent Public Roadmap Sep 29, 2022
@prmukherj prmukherj moved this from Selected to Ongoing in PyFluent Public Roadmap Oct 2, 2022
@prmukherj prmukherj moved this from Ongoing to Selected in PyFluent Public Roadmap Oct 4, 2022
Repository owner moved this from Selected to Ongoing in PyFluent Public Roadmap Oct 18, 2022
@seanpearsonuk seanpearsonuk moved this from Ongoing to Done in PyFluent Public Roadmap Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 2021-2024
Development

Successfully merging a pull request may close this issue.

2 participants