Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added sphinx hook and mordern download buttons #500

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

moe-ad
Copy link
Contributor

@moe-ad moe-ad commented Nov 26, 2024

Description

This pull request will close #490 and close #ansys-internal/pyansys-planning#96. The style of the download buttons on the example pages were improved and this was achieved by implementing a simple sphinx hook.

Checklist

  • I have tested these changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have linked the issue(s) addressed by this PR if any.

@moe-ad moe-ad self-assigned this Nov 26, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New features or code improvements labels Nov 26, 2024
@moe-ad moe-ad requested a review from jorgepiloto November 26, 2024 16:01
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's proceed this way for the moment. The best approach is to have all the logic within the conf.py. We can open an issue about it and address this in the future.

@moe-ad moe-ad marked this pull request as ready for review November 26, 2024 16:21
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.45%. Comparing base (1231ec2) to head (79590b6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files          64       64           
  Lines        2599     2599           
=======================================
  Hits         2403     2403           
  Misses        196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moe-ad moe-ad merged commit 28fa37e into main Nov 26, 2024
21 checks passed
@moe-ad moe-ad deleted the feat/modernize-examples-download-buttons branch November 26, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the style of the examples
2 participants