Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linkchecker and cheatsheet links #3589

Merged
merged 6 commits into from
Nov 29, 2024
Merged

fix: linkchecker and cheatsheet links #3589

merged 6 commits into from
Nov 29, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 28, 2024

Description

As the title.

Issue linked

Close #3588

Checklist

@germa89 germa89 requested a review from a team as a code owner November 28, 2024 10:37
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 28, 2024 10:37
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) bug Issue, problem or error in PyMAPDL labels Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (93f9906) to head (6bf1d90).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3589   +/-   ##
=======================================
  Coverage   86.98%   86.99%           
=======================================
  Files         187      187           
  Lines       14623    14623           
=======================================
+ Hits        12720    12721    +1     
+ Misses       1903     1902    -1     

doc/source/conf.py Outdated Show resolved Hide resolved
@germa89
Copy link
Collaborator Author

germa89 commented Nov 29, 2024

Run https://github.com/ansys/pymapdl/actions/runs/12089283639 got successful.

GitHub
Pythonic interface to MAPDL. Contribute to ansys/pymapdl development by creating an account on GitHub.

@germa89
Copy link
Collaborator Author

germa89 commented Nov 29, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 enabled auto-merge (squash) November 29, 2024 18:59
@germa89 germa89 merged commit 89bd649 into main Nov 29, 2024
47 of 49 checks passed
@germa89 germa89 deleted the fix/link-checker branch November 29, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinkChecker is failing (again)
3 participants