From a84edf3f781742faee3eed7a0c5def7e45128f5a Mon Sep 17 00:00:00 2001 From: Kevin Wenger Date: Mon, 11 Mar 2024 16:57:06 +0100 Subject: [PATCH] annotate tests requiring 3rd party modules Paragraphs --- .gitlab-ci.yml | 8 ++++++-- Dockerfile | 1 - composer.json | 8 +++++++- .../tests/src/Kernel/ParagraphFactoryTest.php | 1 + .../Kernel/ParagraphFieldEntityReferenceFactoryTest.php | 1 + .../tests/src/Kernel/ParagraphFieldFactoryTest.php | 1 + .../tests/src/Kernel/ParagraphTypeFactoryTest.php | 1 + 7 files changed, 17 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 9e884ad..dace54f 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -37,11 +37,15 @@ variables: OPT_IN_TEST_NEXT_MINOR: '1' # Opt in to testing $CORE_PREVIOUS_MAJOR (currently Drupal 9.5). OPT_IN_TEST_PREVIOUS_MAJOR: '1' - # The 4.x branch of the CDN module requires PHP >=8.1, rather than core's >=7.4. + # The current branch of the module requires PHP >=8.1 minimum. CORE_PREVIOUS_PHP_MIN: '8.1' # Opt in to testing $CORE_MAJOR_DEVELOPMENT (currently Drupal 11). - OPT_IN_TEST_NEXT_MAJOR: '1' + # OPT_IN_TEST_NEXT_MAJOR: '1' # This module wants to strictly comply with Drupal's coding standards. +cspell: + allow_failure: false phpcs: allow_failure: false +phpstan: + allow_failure: false diff --git a/Dockerfile b/Dockerfile index bdcc73c..b9ebbd9 100644 --- a/Dockerfile +++ b/Dockerfile @@ -9,7 +9,6 @@ ENV BASE_IMAGE_TAG=${BASE_IMAGE_TAG} # Install drupal/paragraphs as required by entity_to_text_paragraphs RUN COMPOSER_MEMORY_LIMIT=-1 composer require "drupal/paragraphs:^1.14" -RUN COMPOSER_MEMORY_LIMIT=-1 composer require --dev "drupal/entity_browser" # Register the Drupal and DrupalPractice Standard with PHPCS. RUN ./vendor/bin/phpcs --config-set installed_paths \ diff --git a/composer.json b/composer.json index 5904bff..63a590b 100644 --- a/composer.json +++ b/composer.json @@ -17,12 +17,18 @@ "role": "Author & Maintainer" } ], + "repositories": [ + { + "type": "composer", + "url": "https://packages.drupal.org/8" + } + ], "support": { "issues": "https://www.drupal.org/project/issues/factory_lollipop" }, "license": "GPL-2.0-or-later", "require-dev": { - "drupal/coder": "^8.3.1" + "drupal/paragraphs": "^1" }, "config": { "allow-plugins": { diff --git a/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphFactoryTest.php b/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphFactoryTest.php index eab3b5f..08b3f0a 100644 --- a/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphFactoryTest.php +++ b/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphFactoryTest.php @@ -11,6 +11,7 @@ * @group factory_lollipop * @group factory_lollipop_paragraphs * @group factory_lollipop_example + * @requires module paragraphs */ class ParagraphFactoryTest extends LollipopKernelTestBase { diff --git a/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphFieldEntityReferenceFactoryTest.php b/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphFieldEntityReferenceFactoryTest.php index 7e23bd0..233efda 100644 --- a/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphFieldEntityReferenceFactoryTest.php +++ b/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphFieldEntityReferenceFactoryTest.php @@ -12,6 +12,7 @@ * @group factory_lollipop * @group factory_lollipop_paragraphs * @group factory_lollipop_example + * @requires module paragraphs */ class ParagraphFieldEntityReferenceFactoryTest extends LollipopKernelTestBase { diff --git a/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphFieldFactoryTest.php b/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphFieldFactoryTest.php index 989c523..47fdf67 100644 --- a/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphFieldFactoryTest.php +++ b/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphFieldFactoryTest.php @@ -11,6 +11,7 @@ * @group factory_lollipop * @group factory_lollipop_paragraphs * @group factory_lollipop_example + * @requires module paragraphs */ class ParagraphFieldFactoryTest extends LollipopKernelTestBase { diff --git a/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphTypeFactoryTest.php b/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphTypeFactoryTest.php index 324bdcc..f28f901 100644 --- a/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphTypeFactoryTest.php +++ b/modules/factory_lollipop_paragraphs/tests/modules/factory_lollipop_paragraphs_test/tests/src/Kernel/ParagraphTypeFactoryTest.php @@ -11,6 +11,7 @@ * @group factory_lollipop * @group factory_lollipop_paragraphs * @group factory_lollipop_example + * @requires module paragraphs */ class ParagraphTypeFactoryTest extends LollipopKernelTestBase {