Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[React] Add loading animation to svgwave.in #5

Closed
anup-a opened this issue Oct 16, 2020 · 8 comments
Closed

[React] Add loading animation to svgwave.in #5

anup-a opened this issue Oct 16, 2020 · 8 comments
Assignees
@ansh-saini
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@anup-a
Copy link
Owner

anup-a commented Oct 16, 2020

As of now there is no loading animation till page fully renders.

Task is simple -

  • discuss/suggest the loading animation in thread ( theme compatible )
  • implement a loader in react app

Helpful links - loading.io

PS -try not to use any third-party libraries.
@anup-a anup-a added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 16, 2020
@ansh-saini
Copy link
Contributor

Can I work on this?

@anup-a
Copy link
Owner Author

anup-a commented Oct 16, 2020

Go ahead

@anup-a
Copy link
Owner Author

anup-a commented Oct 16, 2020

Note : stick to simple svgs or css for assets

@ansh-saini
Copy link
Contributor

ansh-saini commented Oct 16, 2020 •
edited
Loading

https://codepen.io/FauxyCoder/full/LYYmKJG
Is something like this okay?
It goes with the theme, and is pretty simple.

@anup-a
Copy link
Owner Author

anup-a commented Oct 16, 2020

Yup. looks elegant. you can change color to default svgwave.in has

@ansh-saini
Copy link
Contributor

ansh-saini commented Oct 16, 2020 •
edited
Loading

Alright. I'm also thinking of removing the box shadow. Since the actual loader would have a small size.
100x100 maybe?
Or is the 400x400 size okay?

@anup-a
Copy link
Owner Author

anup-a commented Oct 16, 2020

100X100 would be better. Actually my initial thoughts were to animate the logo itself.

If you are very well verse with css animation you could try that to . (I can provide assets)
Or else you could continue with this one https://codepen.io/FauxyCoder/full/LYYmKJG

@ansh-saini
Copy link
Contributor

I'm not that great with CSS Animations tbh.
I think I'll proceed with the codepen one.

@ansh-saini ansh-saini mentioned this issue Oct 16, 2020
Merged
@anup-a anup-a closed this as completed Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ansh-saini ansh-saini

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anup-a @ansh-saini