Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading animation to Most used language card #1046

Closed
Andre601 opened this issue May 3, 2021 · 8 comments · Fixed by #2197
Closed

Add loading animation to Most used language card #1046

Andre601 opened this issue May 3, 2021 · 8 comments · Fixed by #2197
Assignees
Labels
enhancement New feature or request. lang-card Issues related to the language card.

Comments

@Andre601
Copy link

Andre601 commented May 3, 2021

Is your feature request related to a problem? Please describe.
N/A

Describe the solution you'd like
The main stats card seems to be the only one having an animation when being loaded*, which is sad when you use other cards like the Most languages one**.

My feature request is to have an animation for this card type too. Right now my idea would be to make the languages appear similar to the text on the stats card (Ease-in-out with 100 transparent to 0 transparent) and have the line showing the distribution of languages "load" (extend from left to right) with each separate language, where each new line will cover less of the previous line to achieve the current look of it.

*I don't use Wakka-time so idk if that one has animations.
**I talk about the compact version.

Describe alternatives you've considered
Only alternative I can see is, if I would implement my own solutions, which isn't as easy for me, especially since I can't code in this particular language.

Additional context

@Andre601
Copy link
Author

Andre601 commented Jun 5, 2021

Not really what I was asking for... at all.

@rickstaa rickstaa added feature lang-card Issues related to the language card. labels Mar 9, 2022
@rickstaa rickstaa added enhancement New feature or request. and removed feature labels Jul 25, 2022
@RedHeadphone
Copy link
Contributor

yeah, animation on top languages card would be really cool. If it's possible I would to implement that.

@rickstaa
Copy link
Collaborator

rickstaa commented Oct 12, 2022

@RedHeadphone amazing that you want to contribute to GRS! 🚀 I assigned you to this issue. Let me know if you have any questions.

@RedHeadphone
Copy link
Contributor

screen-capture.webm
@Andre601 @rickstaa
Is this animation good? right now it only works on compact

@Andre601
Copy link
Author

I no longer use this and therefore don't have a general interest in it anymore.

@rickstaa
Copy link
Collaborator

screen-capture.webm @Andre601 @rickstaa Is this animation good? right now it only works on compact

I think it looks great. Looking forward to your PR! 🔥

@RedHeadphone
Copy link
Contributor

non compact layout animation
screen-capture.webm

@rickstaa
Copy link
Collaborator

@RedHeadphone I like this! Your animation skills are on fire 🔥.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. lang-card Issues related to the language card.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants