Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing color of the "ring"/circle around the rank #2055

Closed
theAbdoSabbagh opened this issue Sep 25, 2022 · 4 comments · Fixed by #2075
Closed

Changing color of the "ring"/circle around the rank #2055

theAbdoSabbagh opened this issue Sep 25, 2022 · 4 comments · Fixed by #2075
Assignees
Labels
enhancement New feature or request. hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed.

Comments

@theAbdoSabbagh
Copy link

Is your feature request related to a problem? Please describe.
I'd like to be able to change the color of the circle surrounding the ranking, I couldn't find a way to do it without themes

Describe the solution you'd like
I guess make it possible just like when changing the background color and such

Describe alternatives you've considered
Themes, but meh

Additional context
Readme Card

GitHub Streak

As you can see I have the "ring" color in the 2nd card customized, I'd like to be able to do that with the first card too

@rickstaa rickstaa added the enhancement New feature or request. label Sep 25, 2022
@rickstaa
Copy link
Collaborator

@Sxvxgee, thanks for your feature request. We currently do not support changing the rank circle. You can create a PR to add this feature. The relevant code can be found here;

stroke: ${titleColor};

If there is enough interest, we might merge it in the future.

@theAbdoSabbagh
Copy link
Author

@Sxvxgee, thanks for your feature request. We currently do not support changing the rank circle. You can create a PR to add this feature. The relevant code can be found here;

stroke: ${titleColor};

If there is enough interest, we might merge it in the future.

I'll try to make a PR soon then

@Pranav2612000
Copy link
Contributor

@Sxvxgee do you plan to work on this? Or can I pick it up?

@theAbdoSabbagh
Copy link
Author

@Sxvxgee do you plan to work on this? Or can I pick it up?

Been busy lately so I guess you can work on it instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants