make new_from_bank to be only for tests #3455
Conversation
|
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @KirillLykov. |
KirillLykov
force-pushed
the
klykov/new-from-bank-test
branch
from
e04b3af
to
892a5a3
Compare
| @@ -119,6 +114,18 @@ use { | |||
| }, | |||
| }; | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
Not sure where to place this, the best place I've found
KirillLykov
force-pushed
the
klykov/new-from-bank-test
branch
from
e50423b
to
ef11ad9
Compare
KirillLykov
added
automerge
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
| @@ -119,6 +114,18 @@ use { | |||
| }, | |||
| }; | |||
|
|
|||
| #[cfg(test)] | |||
* make new_from_bank to be only for tests * moved unnecessary use to cfg(test) * remove new line which breaks checks (cherry picked from commit 4e7f7f7)
) make new_from_bank to be only for tests (#3455) * make new_from_bank to be only for tests * moved unnecessary use to cfg(test) * remove new line which breaks checks (cherry picked from commit 4e7f7f7) Co-authored-by: kirill lykov <[email protected]>
Problem
There is a comment that it is useful for tests, instead I added
#[cfg(test)].Summary of Changes