Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0: Store epoch in MaxAge (backport of #3485) #3501

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 6, 2024

Problem

  • MaxAge stores the last slot in the epoch which is confusing

Summary of Changes

  • Store Epoch instead

Fixes #


This is an automatic backport of pull request #3485 done by [Mergify](https://mergify.com).

(cherry picked from commit 5a6f518)

# Conflicts:
#	core/src/banking_stage/consumer.rs
#	core/src/banking_stage/scheduler_messages.rs
#	core/src/banking_stage/transaction_scheduler/transaction_state.rs
#	core/src/banking_stage/transaction_scheduler/transaction_state_container.rs
@mergify mergify bot requested a review from a team as a code owner November 6, 2024 14:27
@mergify mergify bot added the conflicts label Nov 6, 2024
Copy link
Author

mergify bot commented Nov 6, 2024

Cherry-pick of 5a6f518 has failed:

On branch mergify/bp/v2.0/pr-3485
Your branch is up to date with 'origin/v2.0'.

You are currently cherry-picking commit 5a6f518c60.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   core/src/banking_stage/consume_worker.rs
	modified:   core/src/banking_stage/transaction_scheduler/prio_graph_scheduler.rs
	modified:   core/src/banking_stage/transaction_scheduler/scheduler_controller.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   core/src/banking_stage/consumer.rs
	both modified:   core/src/banking_stage/scheduler_messages.rs
	both modified:   core/src/banking_stage/transaction_scheduler/transaction_state.rs
	both modified:   core/src/banking_stage/transaction_scheduler/transaction_state_container.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@apfitzge apfitzge requested a review from jstarry November 6, 2024 18:15
@apfitzge apfitzge merged commit 0348991 into v2.0 Nov 7, 2024
38 checks passed
@apfitzge apfitzge deleted the mergify/bp/v2.0/pr-3485 branch November 7, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants