-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify forward packet batches #3642
simplify forward packet batches #3642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
simplify forward packet batches - nonzero, no branching (cherry picked from commit 2cb11a7) # Conflicts: # core/src/banking_stage/forward_packet_batches_by_accounts.rs
simplify forward packet batches - nonzero, no branching (cherry picked from commit 2cb11a7) # Conflicts: # core/src/banking_stage/forward_packet_batches_by_accounts.rs
* simplify forward packet batches (#3642) simplify forward packet batches - nonzero, no branching (cherry picked from commit 2cb11a7) # Conflicts: # core/src/banking_stage/forward_packet_batches_by_accounts.rs * resolve conflicts --------- Co-authored-by: Andrew Fitzgerald <[email protected]>
* simplify forward packet batches (#3642) simplify forward packet batches - nonzero, no branching (cherry picked from commit 2cb11a7) # Conflicts: # core/src/banking_stage/forward_packet_batches_by_accounts.rs * resolve conflicts --------- Co-authored-by: Andrew Fitzgerald <[email protected]>
Problem
logic in this structure can be simplified
Summary of Changes
NonZeroU64
to avoid doingchecked_div
every packetFixes #