Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify forward packet batches #3642

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

apfitzge
Copy link

Problem

logic in this structure can be simplified

Summary of Changes

  • Use NonZeroU64 to avoid doing checked_div every packet
  • Remove branching
  • make testing simpler

Fixes #

@apfitzge apfitzge marked this pull request as ready for review November 14, 2024 21:03
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge added v2.0 Backport to v2.0 branch v2.1 Backport to v2.1 branch automerge automerge Merge this Pull Request automatically once CI passes labels Nov 14, 2024
Copy link

mergify bot commented Nov 14, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

Copy link

mergify bot commented Nov 14, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@mergify mergify bot merged commit 2cb11a7 into anza-xyz:master Nov 14, 2024
43 checks passed
mergify bot pushed a commit that referenced this pull request Nov 14, 2024
simplify forward packet batches - nonzero, no branching

(cherry picked from commit 2cb11a7)

# Conflicts:
#	core/src/banking_stage/forward_packet_batches_by_accounts.rs
mergify bot pushed a commit that referenced this pull request Nov 14, 2024
simplify forward packet batches - nonzero, no branching

(cherry picked from commit 2cb11a7)

# Conflicts:
#	core/src/banking_stage/forward_packet_batches_by_accounts.rs
@apfitzge apfitzge deleted the simpify_forward_packet_batches branch November 14, 2024 23:07
apfitzge added a commit that referenced this pull request Nov 15, 2024
* simplify forward packet batches (#3642)

simplify forward packet batches - nonzero, no branching

(cherry picked from commit 2cb11a7)

# Conflicts:
#	core/src/banking_stage/forward_packet_batches_by_accounts.rs

* resolve conflicts

---------

Co-authored-by: Andrew Fitzgerald <[email protected]>
apfitzge added a commit that referenced this pull request Nov 15, 2024
* simplify forward packet batches (#3642)

simplify forward packet batches - nonzero, no branching

(cherry picked from commit 2cb11a7)

# Conflicts:
#	core/src/banking_stage/forward_packet_batches_by_accounts.rs

* resolve conflicts

---------

Co-authored-by: Andrew Fitzgerald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes v2.0 Backport to v2.0 branch v2.1 Backport to v2.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants