v2.1: remove ntapi patch (backport of #3584) #3666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* use anza-xyz/ntapi instead of the labs one * remove ntapi patch * fix shellcheck (cherry picked from commit da90cbe)
|
I think this should be safe because: 1) we don't need ntapi anymore and 2) ntapi has released a new version with the commit we need. If we missed anything, it should still pick the correct version to use |
t-nelson
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
we should use anza-xyz/ntapi as the vendor. just forked it and the commit, https://github.com/anza-xyz/ntapi/commits/97ede981a1777883ff86d142b75024b023f04fad, is reachableremove outdated patch
This is an automatic backport of pull request #3584 done by [Mergify](https://mergify.com).