Cleanup - Removes the owner form the result of filter_executable_program_accounts()
#879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts(). Updates the description of the function.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #879 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 853 853
Lines 231782 231775 -7
=======================================
+ Hits 189754 189763 +9
+ Misses 42028 42012 -16 |
dmakarov
approved these changes
Apr 18, 2024
michaelschem
pushed a commit
to michaelschem/agave
that referenced
this pull request
Apr 20, 2024
…gram_accounts()` (anza-xyz#879) Removes the owner form the result of filter_executable_program_accounts(). Updates the description of the function.
Lichtso
added a commit
that referenced
this pull request
Nov 7, 2024
Lichtso
added a commit
that referenced
this pull request
Nov 8, 2024
Lichtso
added a commit
that referenced
this pull request
Nov 8, 2024
Revert - #879 and #768 (#3521) * Revert "Cleanup - Removes the owner form the result of `filter_executable_program_accounts()` (#879)" This reverts commit 5fe30cb. * Revert "Refactor - Remove `program_accounts_map` from account_loader (#768)" This reverts commit e7617a1. (cherry picked from commit 57bdb8e) Co-authored-by: Alexander Meißner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After #768 the owner field produced by
filter_executable_program_accounts()is no longer consumed anywhere.Summary of Changes
filter_executable_program_accounts()